From: Mark Walters Date: Mon, 3 Jun 2013 16:28:24 +0000 (+0100) Subject: Re: [RFC PATCH] emacs: Remove v command X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9e3d341de85fc5ff32e2f1d802ac5da433741294;p=notmuch-archives.git Re: [RFC PATCH] emacs: Remove v command --- diff --git a/3c/f057d9a9a5c6f24876cb30c81b89f2c5f8e15c b/3c/f057d9a9a5c6f24876cb30c81b89f2c5f8e15c new file mode 100644 index 000000000..094b5035f --- /dev/null +++ b/3c/f057d9a9a5c6f24876cb30c81b89f2c5f8e15c @@ -0,0 +1,114 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1989A431FAF + for ; Mon, 3 Jun 2013 09:28:45 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XUBQLWqjImYZ for ; + Mon, 3 Jun 2013 09:28:37 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 48622431FAE + for ; Mon, 3 Jun 2013 09:28:37 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1UjXcP-0002fa-Vi; Mon, 03 Jun 2013 17:28:33 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1UjXcP-0000DZ-Ny; Mon, 03 Jun 2013 17:28:25 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [RFC PATCH] emacs: Remove v command +In-Reply-To: <1370274895-32098-1-git-send-email-amdragon@mit.edu> +References: <1370274895-32098-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Mon, 03 Jun 2013 17:28:24 +0100 +Message-ID: <87ehcjf9av.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: e107f8a2901f6efc6247be86f0d4443a (of first 20000 bytes) +X-SpamAssassin-Score: -0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.0 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 03 Jun 2013 16:28:45 -0000 + + +I like the change. +1 from me. + +Mark + +Austin Clements writes: + +> This removes the v command, since we now have much nicer part commands, +> and deprecates the underlying notmuch-show-view-all-mime-parts. This +> also means that people who try using the old unprefixed 'v' command on +> a part button will no longer be greeted by ALL of their parts popping +> up. +> --- +> emacs/notmuch-show.el | 4 +++- +> 1 file changed, 3 insertions(+), 1 deletion(-) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 5771950..bae3171 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a +> "Enable Visual Line mode." +> (visual-line-mode t)) +> +> +;; DEPRECATED in Notmuch 0.16 since we now have convenient part +> +;; commands. We'll keep the command around for a version or two in +> +;; case people want to bind it themselves. +> (defun notmuch-show-view-all-mime-parts () +> "Use external viewers to view all attachments from the current message." +> (interactive) +> @@ -1216,7 +1219,6 @@ reset based on the original query." +> (define-key map "|" 'notmuch-show-pipe-message) +> (define-key map "w" 'notmuch-show-save-attachments) +> (define-key map "V" 'notmuch-show-view-raw-message) +> - (define-key map "v" 'notmuch-show-view-all-mime-parts) +> (define-key map "c" 'notmuch-show-stash-map) +> (define-key map "=" 'notmuch-show-refresh-view) +> (define-key map "h" 'notmuch-show-toggle-visibility-headers) +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch