From: Zac Medico <zmedico@gentoo.org>
Date: Tue, 17 Mar 2009 05:52:27 +0000 (-0000)
Subject: Bug #262365 - Punt the prepalldocs check until there is an alternative
X-Git-Tag: v2.2_rc26~2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9da1ab2d6d894d784f9020688302743ce641fa30;p=portage.git

Bug #262365 - Punt the prepalldocs check until there is an alternative
available in EAPI 3.

svn path=/main/trunk/; revision=13118
---

diff --git a/bin/repoman b/bin/repoman
index b3f9a92fc..27d65e9f9 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -313,7 +313,6 @@ qahelp={
 	"metadata.missing":"Missing metadata.xml files",
 	"metadata.bad":"Bad metadata.xml files",
 	"metadata.warning":"Warnings in metadata.xml files",
-	"portage.internal":"The ebuild uses an internal Portage function",
 	"virtual.versioned":"PROVIDE contains virtuals with versions",
 	"virtual.exists":"PROVIDE contains existing package names",
 	"virtual.unavailable":"PROVIDE contains a virtual which contains no profile default",
@@ -352,7 +351,6 @@ qawarnings = set((
 "inherit.autotools",
 "java.eclassesnotused",
 "metadata.warning",
-"portage.internal",
 "virtual.versioned",
 "virtual.exists",
 "virtual.unavailable",
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index a9e29d2be..458812057 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -345,15 +345,6 @@ class WantAutoDefaultValue(LineCheck):
 			return 'WANT_AUTO' + m.group(1) + \
 				' redundantly set to default value "latest" on line: %d'
 
-class PortageInternal(LineCheck):
-	"""
-	In February 2009 the Gentoo council ruled that
-	prepalldocs is a Portage internal.
-	"""
-	repoman_check_name = 'portage.internal'
-	re = re.compile(r'[^#]*\bprepalldocs\b')
-	error = errors.PREPALLDOCS_ERROR
-
 _constant_checks = tuple((c() for c in (
 	EbuildHeader, EbuildWhitespace, EbuildQuote,
 	EbuildAssignment, EbuildUselessDodoc,
@@ -361,7 +352,7 @@ _constant_checks = tuple((c() for c in (
 	EbuildPatches, EbuildQuotedA,
 	IUseUndefined, ImplicitRuntimeDeps, InheritAutotools,
 	EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS,
-	DeprecatedBindnowFlags, WantAutoDefaultValue, PortageInternal)))
+	DeprecatedBindnowFlags, WantAutoDefaultValue)))
 
 def run_checks(contents, pkg):
 	checks = _constant_checks
diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py
index 451e499ad..2e13e0d67 100644
--- a/pym/repoman/errors.py
+++ b/pym/repoman/errors.py
@@ -16,4 +16,3 @@ REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d'
 EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake -j1 on line: %d)'
 EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS = 'Upstream parallel compilation bug (MAKEOPTS=-j1 on line: %d)'
 DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'
-PREPALLDOCS_ERROR = 'prepalldocs called on line: %d'