From: Junio C Hamano Date: Wed, 29 Jun 2005 00:49:27 +0000 (-0700) Subject: [PATCH] Emit base objects of a delta chain when the delta is output. X-Git-Tag: v0.99~133 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9d5ab9625ddb53a68a99516225d0bcb39ec473d5;p=git.git [PATCH] Emit base objects of a delta chain when the delta is output. Deltas are useless by themselves and when you use them you need to get to their base objects. A base object should inherit recency from the most recent deltified object that is based on it and that is what this patch teaches git-pack-objects. Signed-off-by: Junio C Hamano Signed-off-by: Linus Torvalds --- diff --git a/pack-objects.c b/pack-objects.c index 36f515b73..feee5600b 100644 --- a/pack-objects.c +++ b/pack-objects.c @@ -118,6 +118,23 @@ static unsigned long write_object(struct sha1file *f, struct object_entry *entry return hdrlen + datalen; } +static unsigned long write_one(struct sha1file *f, + struct object_entry *e, + unsigned long offset) +{ + if (e->offset) + /* offset starts from header size and cannot be zero + * if it is written already. + */ + return offset; + e->offset = offset; + offset += write_object(f, e); + /* if we are delitified, write out its base object. */ + if (e->delta) + offset = write_one(f, e->delta, offset); + return offset; +} + static void write_pack_file(void) { int i; @@ -135,11 +152,9 @@ static void write_pack_file(void) hdr.hdr_entries = htonl(nr_objects); sha1write(f, &hdr, sizeof(hdr)); offset = sizeof(hdr); - for (i = 0; i < nr_objects; i++) { - struct object_entry *entry = objects + i; - entry->offset = offset; - offset += write_object(f, entry); - } + for (i = 0; i < nr_objects; i++) + offset = write_one(f, objects + i, offset); + sha1close(f, pack_file_sha1, 1); mb = offset >> 20; offset &= 0xfffff;