From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 11 Feb 2014 14:14:45 +0000 (+0200)
Subject: Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9d18097ed687fcf9179039c76065e8e2d38f32de;p=notmuch-archives.git

Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale
---

diff --git a/ab/8c303525f557f975b1ed9c7fdc53a3b9474b18 b/ab/8c303525f557f975b1ed9c7fdc53a3b9474b18
new file mode 100644
index 000000000..e28e18722
--- /dev/null
+++ b/ab/8c303525f557f975b1ed9c7fdc53a3b9474b18
@@ -0,0 +1,107 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id BDF44431FC0
+	for <notmuch@notmuchmail.org>; Tue, 11 Feb 2014 06:14:57 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id e1dJWmdliq9i for <notmuch@notmuchmail.org>;
+	Tue, 11 Feb 2014 06:14:51 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id A06BC431FBD
+	for <notmuch@notmuchmail.org>; Tue, 11 Feb 2014 06:14:51 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 718A21000FA;
+	Tue, 11 Feb 2014 16:14:45 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, "W. Trevor King" <wking@tremily.us>,
+	notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's
+	locale
+In-Reply-To: <87eh396e6e.fsf@zancas.localnet>
+References: <cover.1392056624.git.wking@tremily.us>
+	<deff072f78f4a7c5b0774e67a8f0517cc704725d.1392056624.git.wking@tremily.us>
+	<87eh396e6e.fsf@zancas.localnet>
+User-Agent: Notmuch/0.17+69~g761b031 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Tue, 11 Feb 2014 16:14:45 +0200
+Message-ID: <m2sirpu46i.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 11 Feb 2014 14:14:57 -0000
+
+On Tue, Feb 11 2014, David Bremner <david@tethera.net> wrote:
+
+> "W. Trevor King" <wking@tremily.us> writes:
+>
+>> Instead of always writing UTF-8, allow the user to configure the
+>> output encoding using their locale.  This is useful for previewing
+>> output in the terminal, for poor souls that don't use UTF-8 locales
+>> ;).
+>
+> This (or some other patch in the series) seems to cause some problems on
+> the production instance:
+>
+> remote: Traceback (most recent call last):
+> remote:   File "/home/nmbug/tools/nmbug-status", line 336, in <module>
+> remote:     page.write(database=db, views=config['views'])
+> remote:   File "/home/nmbug/tools/nmbug-status", line 96, in write
+> remote:     self._write_view(database=database, view=view, stream=stream)
+> remote:   File "/home/nmbug/tools/nmbug-status", line 115, in _write_view
+> remote:     self._write_threads(threads=threads, stream=stream)
+> remote:   File "/home/nmbug/tools/nmbug-status", line 219, in _write_threads
+> remote:     ).format(**message_display_data))
+> remote:   File "/usr/lib/python2.6/codecs.py", line 351, in write
+> remote:     data, consumed = self.encode(object, self.errors)
+> remote: UnicodeEncodeError: 'ascii' codec can't encode character u'\u017b' in position 219: ordinal not in range(128)
+>
+> possibly because of
+>
+> LANG=C
+> LANGUAGE=
+> LC_CTYPE="C"
+> LC_NUMERIC="C"
+> LC_TIME="C"
+> LC_COLLATE="C"
+> LC_MONETARY="C"
+> LC_MESSAGES="C"
+> LC_PAPER="C"
+> LC_NAME="C"
+> LC_ADDRESS="C"
+> LC_TELEPHONE="C"
+> LC_MEASUREMENT="C"
+> LC_IDENTIFICATION="C"
+> LC_ALL=C
+>
+> I think it's fine to _allow_ the user to configure the output encoding. I'm
+> less sure about _requiring_ it.
+
+That reminded me that yesterday (after review, of course) I thought that 
+we probably want configuration file to be parsed as utf-8 instead of
+any encoding user may have in their system...
+
+> d
+
+Tomi