From: Mark Walters Date: Tue, 6 May 2014 18:52:58 +0000 (+0100) Subject: Re: [PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9aad0db9b7cf06fa9583eb42ea12ea00fa6b43ce;p=notmuch-archives.git Re: [PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'. --- diff --git a/23/8e2a2bbf4c3d5d1f5a7174db2bef0e3b44de46 b/23/8e2a2bbf4c3d5d1f5a7174db2bef0e3b44de46 new file mode 100644 index 000000000..98ab2225f --- /dev/null +++ b/23/8e2a2bbf4c3d5d1f5a7174db2bef0e3b44de46 @@ -0,0 +1,131 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 17F66431FC2 + for ; Tue, 6 May 2014 11:53:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EBgFwyh9crlX for ; + Tue, 6 May 2014 11:53:03 -0700 (PDT) +Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 69C12431FAF + for ; Tue, 6 May 2014 11:53:03 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail1.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WhkU8-0000YR-Pp; Tue, 06 May 2014 19:53:01 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WhkU8-0007Hn-I6; Tue, 06 May 2014 19:53:00 +0100 +From: Mark Walters +To: Tomi Ollila , David Edmondson , + notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Correct the documentation + for `notmuch-search-line-faces'. +In-Reply-To: +References: + <1399370610-7146-1-git-send-email-dme@dme.org> + +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 06 May 2014 19:52:58 +0100 +Message-ID: <8738gmu4c5.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 4930162e5dda3ee8f48e067fe5a8ba80 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 06 May 2014 18:53:11 -0000 + + +LGTM too +1 + +Mark + +On Tue, 06 May 2014, Tomi Ollila wrote: +> On Tue, May 06 2014, David Edmondson wrote: +> +>> The implementation and documentation for `notmuch-search-line-faces' +>> disagreed in how elements in the list were merged. Correct the +>> documentation to match the implementation (that is, the earlier +>> elements in the list have precedence over later elements). +> +> LGTM. +> +> Tomi +> +> +> +>> --- +>> emacs/notmuch.el | 10 +++++----- +>> 1 file changed, 5 insertions(+), 5 deletions(-) +>> +>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +>> index 6c0bc1b..8aa0104 100644 +>> --- a/emacs/notmuch.el +>> +++ b/emacs/notmuch.el +>> @@ -647,12 +647,12 @@ of the result." +>> Here is an example of how to color search results based on tags. +>> (the following text would be placed in your ~/.emacs file): +>> +>> - (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\" +>> - :background \"blue\")) +>> - (\"unread\" . (:foreground \"green\")))) +>> + (setq notmuch-search-line-faces '((\"unread\" . (:foreground \"green\")) +>> + (\"deleted\" . (:foreground \"red\" +>> + :background \"blue\")))) +>> +>> -The attributes defined for matching tags are merged, with later +>> -attributes overriding earlier. A message having both \"deleted\" +>> +The attributes defined for matching tags are merged, with earlier +>> +attributes overriding later. A message having both \"deleted\" +>> and \"unread\" tags with the above settings would have a green +>> foreground and blue background." +>> :type '(alist :key-type (string) :value-type (custom-face-edit)) +>> -- +>> 2.0.0.rc0 +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch