From: Tomi Ollila Date: Sat, 11 Jan 2014 10:14:37 +0000 (+0200) Subject: Re: [PATCH] test/emacs: replace the use of process-attributes with kill(1) X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=99d37b2302acec1c46da5f3c088a9705a93ee9db;p=notmuch-archives.git Re: [PATCH] test/emacs: replace the use of process-attributes with kill(1) --- diff --git a/8a/2af49f19f77d94a2abea610fad3014b6c9c2f7 b/8a/2af49f19f77d94a2abea610fad3014b6c9c2f7 new file mode 100644 index 000000000..eeeeed1d0 --- /dev/null +++ b/8a/2af49f19f77d94a2abea610fad3014b6c9c2f7 @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 453C2431FC3 + for ; Sat, 11 Jan 2014 02:14:52 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QePZxCG0o7EE for ; + Sat, 11 Jan 2014 02:14:44 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 9CFBF431FC0 + for ; Sat, 11 Jan 2014 02:14:44 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 6201A10005E; + Sat, 11 Jan 2014 12:14:38 +0200 (EET) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] test/emacs: replace the use of process-attributes with + kill(1) +In-Reply-To: <1389407778-15724-1-git-send-email-david@tethera.net> +References: <87a9ffofsc.fsf@zancas.localnet> + <1389407778-15724-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.17+23~ga575e35 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 11 Jan 2014 10:14:52 -0000 + +On Sat, Jan 11 2014, David Bremner wrote: + +> In some environments (at least Hurd), process-attributes is +> unimplimented and always returns nil. This ends up causing test +> failures (see e.g. id:87a9ffofsc.fsf@zancas.localnet). +> +> According to POSIX 1003.1-2001, a signal of 0 can be used to check the +> validity of a pid. This seems less heinous than parsing the output of ps(1). +> --- + +This has been pretty portable method long before 2001 :D + +You could replace the call-process with + +(signal-process pid 0) + +Tomi + +> +> I'm not sure if it would be worthwhile, but a point release could +> finally get notmuch compiling on Hurd again. At least the test in the parent message does pass on Hurd with this patch +> +> test/test-lib.el | 15 +++++++++------ +> 1 file changed, 9 insertions(+), 6 deletions(-) +> +> diff --git a/test/test-lib.el b/test/test-lib.el +> index d26b49f..93f5f72 100644 +> --- a/test/test-lib.el +> +++ b/test/test-lib.el +> @@ -77,19 +77,22 @@ invisible text." +> (setq start next-pos))) +> str)) +> +> +;; process-attributes is not defined everywhere, so define an +> +;; alternate way to test if a process still exists. +> + +> +(defun test-process-running (pid) +> + (= 0 +> + (call-process "kill" nil nil nil "-0" (int-to-string pid)))) +> + +> (defun orphan-watchdog-check (pid) +> "Periodically check that the process with id PID is still +> running, quit if it terminated." +> - (if (not (process-attributes pid)) +> + (if (not (test-process-running pid)) +> (kill-emacs))) +> +> (defun orphan-watchdog (pid) +> "Initiate orphan watchdog check." +> - ; If process-attributes returns nil right away, that probably means +> - ; it is unimplimented. So we delay two minutes before killing emacs. +> - (if (process-attributes pid) +> - (run-at-time 60 60 'orphan-watchdog-check pid) +> - (run-at-time 120 60 'orphan-watchdog-check pid))) +> + (run-at-time 60 60 'orphan-watchdog-check pid)) +> +> (defun hook-counter (hook) +> "Count how many times a hook is called. Increments +> -- +> 1.8.5.2 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch