From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 9 Feb 2014 09:34:39 +0000 (+0200)
Subject: Re: [PATCH 15/17] nmbug-status: Quote the title when using it as an id
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9991bcd3c7d35d2e253b97cc991f863eda00207d;p=notmuch-archives.git

Re: [PATCH 15/17] nmbug-status: Quote the title when using it as an id
---

diff --git a/33/b87a4892c059b8881b429db255b16d3045b368 b/33/b87a4892c059b8881b429db255b16d3045b368
new file mode 100644
index 000000000..2c8fb1739
--- /dev/null
+++ b/33/b87a4892c059b8881b429db255b16d3045b368
@@ -0,0 +1,76 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 0D002431FBD
+	for <notmuch@notmuchmail.org>; Sun,  9 Feb 2014 01:34:52 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id FD6k5AfggLhm for <notmuch@notmuchmail.org>;
+	Sun,  9 Feb 2014 01:34:48 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 8B95C431FBC
+	for <notmuch@notmuchmail.org>; Sun,  9 Feb 2014 01:34:48 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 26E9F1000B2;
+	Sun,  9 Feb 2014 11:34:40 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 15/17] nmbug-status: Quote the title when using it as an
+ id
+In-Reply-To: <20140208231804.GE17142@odin.tremily.us>
+References: <cover.1391424512.git.wking@tremily.us>
+	<1e32bfd3b971aea8842fa29a3f7adc5a552a0f79.1391424512.git.wking@tremily.us>
+	<20140208231804.GE17142@odin.tremily.us>
+User-Agent: Notmuch/0.17+69~g761b031 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 09 Feb 2014 11:34:39 +0200
+Message-ID: <m2bnygzl1s.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 09 Feb 2014 09:34:52 -0000
+
+On Sun, Feb 09 2014, "W. Trevor King" <wking@tremily.us> wrote:
+
+> On Mon, Feb 03, 2014 at 02:59:33AM -0800, W. Trevor King wrote:
+>> +            if 'id' not in view:
+>> +                view['id'] = quote(view['title'])
+>
+> Stuff like href="#Maybe%20Ready%20%28Core%20and%20Emacs%29" wasn't
+> working for me on Firefox 24.2.0, so I've tweaked this commit to slug
+> titles instead of quoting them.  Pushed to my nmbug-status-python3
+> branch and queued for my v2 submission.
+
+$ git checkout nmbug-status-python3
+$ git pull --rebase
+$ ./devel/nmbug/nmbug-status
+
+Looks pretty good to me. I am not sure whether the commit messages should
+be *that* verbose, though...
+
+>
+> Cheers,
+> Trevor
+
+Tomi