From: Jameson Graef Rollins Date: Sun, 17 Nov 2013 19:37:57 +0000 (+1600) Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=98b18584fe9bfcec3393044c24ccefa5b99a7379;p=notmuch-archives.git Re: [PATCH] emacs: do not put quoted reply in primary selection --- diff --git a/ce/de768c68aab6f7147c64893bf575a8cef731e3 b/ce/de768c68aab6f7147c64893bf575a8cef731e3 new file mode 100644 index 000000000..a911f959f --- /dev/null +++ b/ce/de768c68aab6f7147c64893bf575a8cef731e3 @@ -0,0 +1,109 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2F0B4431FD4 + for ; Sun, 17 Nov 2013 11:38:17 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XzpwRbjDOIC9 for ; + Sun, 17 Nov 2013 11:38:11 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 95190431FAF + for ; Sun, 17 Nov 2013 11:38:11 -0800 (PST) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 1CCCF66E00FF; + Sun, 17 Nov 2013 11:38:11 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (unknown [198.129.209.202]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 71C2966E011F; + Sun, 17 Nov 2013 11:38:05 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id A15D26008E; Sun, 17 Nov 2013 11:38:00 -0800 (PST) +From: Jameson Graef Rollins +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection +In-Reply-To: <1384689849-9388-1-git-send-email-markwalters1009@gmail.com> +References: <1384689849-9388-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.16+168~gf3d6c8c (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 17 Nov 2013 11:37:57 -0800 +Message-ID: <87siuu95uy.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 17 Nov 2013 19:38:17 -0000 + +--=-=-= +Content-Type: text/plain + +On Sun, Nov 17 2013, Mark Walters wrote: +> In current emacs (24.3) select-active-regions is set to t by +> default. The reply insertion code sets the region to the quoted +> message to make it easy to delete (kill-region or C-w). These two +> things combine to put the quoted message in the primary selection. +> +> This is not what the user wanted and is a privacy risk (accidental +> pasting of the quoted message). We can avoid some of the problems +> by let-binding select-active-regions to nil. This fixes if the +> primary selection was previously in a non-emacs window but not if +> it was in an emacs window. To avoid the problem in the latter case +> we deactivate mark. +> +> One key test (which fails under many simpler "fixes") is: open emacs +> 24.3 with notmuch, open 2 windows (viewing different notmuch buffers), +> highlight some text in one, and then reply to a message in the +> other. In many of my earlier attempts to fix this big this test fails. + +I'm very happy to report that I reply to this message with an unpolluted +paste buffer! Kudos Mark! + +> Anyway, this is the best I can manage! + +Too modest for such an achievement. + ++10 + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.15 (GNU/Linux) + +iQIcBAEBCAAGBQJSiRsWAAoJEO00zqvie6q8IbgP/0dwCT/d11gLDuei92DcisKq +AUkTcUtcUMIUrahoosvVnJcXt1qXDnRhmfsj7DGArVEkRkF/Zol+eettsrmAfxPG +iHkp4QAxFA20pw69rDI9wXsAuwda2dWvU+Yl8tL6IM/kA7x6odnbH0Vogggum5YR +s5c/grCkRmhgBDOjY+9L5Qrgj/RUH5vAVDaX2Fu8nbnGu7EUR3a/eL0bFjgYZlrJ +xZXANlVRr0tSgMc8eiLI9kdXOV7owT0iRDNaTpu3MN1s98qn67DIbrSrw/8+k6Ie +fxa4wVV7EAswENTy3PcI6LB9UltgGp+gZEaTP8RoXJlhO+VPTXyUwfJTlWSZt6+I +tkqWs31XvSm3Eo53brNRtgpaHV2clE69U4C/pqFbKgkQfTD5VK7n2pZiF9PPCNPZ +90lHcT6i5AJGcGZxxHnr2yOD0RFMYUZucdTu0jWq6w6TPtB4chzfmUiVYt9xfoqD +oPz+yWa9Yiavmzcso3dI68FBA4L0mqI3KLq4afYcjk6rHrAha4D2gX1IK8U3GaWA +ynKtFQdMA7GxOswIN6dQXDBR8R2iNzjDRIi63Emm8NDVzaPWez1vn0VXOuSrZjDC +m0klOsA9KyKgJ3qB19JU9LftrsCDcDL3zIbSOkA+rEGIDzwjkG7YG7/bSCTWs3ps +bylJMZ4Fs+0bIkQK+Ym4 +=fcuz +-----END PGP SIGNATURE----- +--=-=-=--