From: David Edmondson Date: Wed, 10 Feb 2016 19:52:17 +0000 (+0000) Subject: Re: [PATCH v2] emacs: Report a lack of matches when calling `notmuch-show'. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=982149bf2693aaf5e63d1b97d683c1518cf51cb1;p=notmuch-archives.git Re: [PATCH v2] emacs: Report a lack of matches when calling `notmuch-show'. --- diff --git a/01/f86c2a02d7540bfeb45d7042919cc8c3163d00 b/01/f86c2a02d7540bfeb45d7042919cc8c3163d00 new file mode 100644 index 000000000..09dbfb3e6 --- /dev/null +++ b/01/f86c2a02d7540bfeb45d7042919cc8c3163d00 @@ -0,0 +1,118 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id A43E36DE0BF6 + for ; Wed, 10 Feb 2016 11:52:23 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.115 +X-Spam-Level: +X-Spam-Status: No, score=-0.115 tagged_above=-999 required=5 + tests=[AWL=-0.048, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pFNKbdTCvKgd for ; + Wed, 10 Feb 2016 11:52:21 -0800 (PST) +Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com + [74.125.82.65]) by arlo.cworth.org (Postfix) with ESMTPS id 5D2496DE0B36 for + ; Wed, 10 Feb 2016 11:52:21 -0800 (PST) +Received: by mail-wm0-f65.google.com with SMTP id g62so6349899wme.2 + for ; Wed, 10 Feb 2016 11:52:21 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:subject:in-reply-to:references:from:date:message-id:mime-version + :content-type; bh=f3uIJvwAJ0naWN3oknSrqGvMbilTu6vQZwbAfyZwQ2A=; + b=FLm3vvzoOKqbmT8QCAsAF1NZzZGxWwsi6AzQrLCd5rs9m0vNbX3z8/mgZbwzGQ9JCt + w7U4Dg/Z+dC+MXwBKdsnYKBzgvc/3E2+vT3sVs7TRbhLPVFbGJuvpHRlHPltBPgzAFvp + xN+aI6qASnfYXbTwBjI7WKp/ehtlLuzBjq9ZTYlcc904c1WufnsYGJsekTKfVTp/6EZs + uA7RY2+AxATERKhUr6PCPhzezlzbfW7PDymSfLqV8qQxpYQjzCYmFA9OlQCMmfHNAfZK + 1qS+oK6nNOtp6UtK65dj6MQasajjwG1hCBMnDrZS9D0gOQaOhQZCUrIFf7O6GwFTpBUZ + V4mA== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:from:date + :message-id:mime-version:content-type; + bh=f3uIJvwAJ0naWN3oknSrqGvMbilTu6vQZwbAfyZwQ2A=; + b=gK776/OXtXOBZHCKJjc1XP1aHMemE0r0U1swnM9HuXBi+aXe50+7DaTPbioY82Oa3C + ooUm8H0Y40qBj2FAhwAojLEh2pElq47TVUl82iNfl702MfNjuuFz5zC0egax26sS4pCf + d/JteP4i/7AXqIJhObYbFrxas5YEHNcVFTh1yEB6DpE1FT+/M0i+gxjpW6Wd3O10+EdA + nmnavOnCdYvoCllnqAD/tK9s/c2IPBKYpKvrlHMOIqnrv+arK+CaBDtuvDQ1r2bEgKjJ + i8eWygAk2Y4T0aM8CIzeW1USzQZRyrOVglVLTsI7rVACLZgZ6tvsqE0xjpXFsdIha4vQ + ouUw== +X-Gm-Message-State: + AG10YORwQ41x/l1aWbyVwh4f2Td0eOcTFl+CL+fsJF7OhAmA9E4s2DklinpN9GaMapmSSg== +X-Received: by 10.28.173.71 with SMTP id w68mr13819810wme.88.1455133939824; + Wed, 10 Feb 2016 11:52:19 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id w136sm23721146wmw.0.2016.02.10.11.52.18 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Wed, 10 Feb 2016 11:52:18 -0800 (PST) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id cab25f7c; + Wed, 10 Feb 2016 19:52:17 +0000 (UTC) +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Report a lack of matches when calling + `notmuch-show'. +In-Reply-To: <87oabo5rix.fsf@qmul.ac.uk> +References: <1455112878-23497-1-git-send-email-dme@dme.org> + <1455112878-23497-2-git-send-email-dme@dme.org> <87oabo5rix.fsf@qmul.ac.uk> +From: David Edmondson +Date: Wed, 10 Feb 2016 19:52:17 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 10 Feb 2016 19:52:23 -0000 + +On Wed, Feb 10 2016, Mark Walters wrote: +> This basically looks fine to me and all tests pass. The code movement +> and cleanup all looks fine. + +Thanks. + +> Two minor things, one tiny nit below; and I wonder whether just having +> the buffer say "No search results" (or something similar) and leave +> the user to kill it would be nicer than dinging (and more in line with +> the way search and tree behave). +> +> [In some sense I think this way is right and search and tree are wrong, +> but that is probably difficult to get round as search and tree run +> asynchronously.] + +What if we did "notmuch count $query" first in the search and tree case, +and did the "(ding) (message ...)" thing if the count returned 0? (Just +wondering about whether having everything behave that way would be +possible and acceptable.) + +The original impetus for this change was someone who hits an id: button +that is either a false match (i.e it wasn't ever intended to be a +notmuch reference) or for a message that they don't have. In both of +those cases popping up a buffer that says only "No match." would be +annoying. If we were considering the case where people are using "M-x +notmuch-show", it seems less clear on the right thing to do, but overall +I prefer this approach to the useless buffer that I have to kill/quit. + +>> + ;; Cache the original tags for each message so that we can display +>> + ;; changes. +> +> ^^ I think "Store the original tags for each message" would be better, +> particularly as this is nothing to do with the tag cache as used by say +> notmuch-tag-clear-cache. + +Agreed - fixed.