From: Theodore Tso <tytso@mit.edu>
Date: Thu, 25 Jul 1996 22:06:40 +0000 (+0000)
Subject: admin_internal.h (_KADM5_CHECK_HANDLE): Add parenthesis around
X-Git-Tag: krb5-1.0-beta7~259
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=97726e821f8a788501941968e031c5205db4d27d;p=krb5.git

admin_internal.h (_KADM5_CHECK_HANDLE): Add parenthesis around
	assignment used as truth value to reduce gcc -Wall flames.

misc_free.c (kadm5_free_name_list, krb5_free_key_data_contents: Add
	KADM5_OK return value upon success.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@8823 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/kadm5/ChangeLog b/src/lib/kadm5/ChangeLog
index ade62cc98..f6be228cb 100644
--- a/src/lib/kadm5/ChangeLog
+++ b/src/lib/kadm5/ChangeLog
@@ -1,3 +1,11 @@
+Thu Jul 25 12:04:32 1996  Theodore Y. Ts'o  <tytso@mit.edu>
+
+	* admin_internal.h (_KADM5_CHECK_HANDLE): Add parenthesis around
+		assignment used as truth value to reduce gcc -Wall flames.
+
+	* misc_free.c (kadm5_free_name_list, krb5_free_key_data_contents: 
+		Add KADM5_OK return value upon success.
+
 Wed Jul 24 18:18:39 1996  Tom Yu  <tlyu@voltage-multiplier.mit.edu>
 
 	* Makefile.in, configure.in: fix shared lib lossage by
diff --git a/src/lib/kadm5/admin_internal.h b/src/lib/kadm5/admin_internal.h
index d73837e67..d2d1533bc 100644
--- a/src/lib/kadm5/admin_internal.h
+++ b/src/lib/kadm5/admin_internal.h
@@ -55,7 +55,7 @@
  * Got that?
  */
 #define _KADM5_CHECK_HANDLE(handle) \
-{ int code; if (code = _kadm5_check_handle((void *)handle)) return code; }
+{ int code; if ((code = _kadm5_check_handle((void *)handle))) return code; }
 
 kadm5_ret_t _kadm5_chpass_principal_util(void *server_handle,
 					 void *lhandle,
diff --git a/src/lib/kadm5/misc_free.c b/src/lib/kadm5/misc_free.c
index cfe28a411..f1cd1278b 100644
--- a/src/lib/kadm5/misc_free.c
+++ b/src/lib/kadm5/misc_free.c
@@ -35,6 +35,7 @@ kadm5_ret_t
     while (count--)
 	  free(names[count]);
      free(names);
+    return KADM5_OK;
 }
 
 
@@ -52,6 +53,7 @@ kadm5_ret_t krb5_free_key_data_contents(context, key)
 	       free(key->key_data_contents[i]);
 	  }
      }
+     return KADM5_OK;
 }
 
 kadm5_ret_t