From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Thu, 13 Feb 2014 06:55:19 +0000 (+0200)
Subject: Re: [PATCH v2] new: Detect dirent.d_type support at configure time
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=96f03e2ea60d8a10863dfc4b35cef85fc14e2c0f;p=notmuch-archives.git

Re: [PATCH v2] new: Detect dirent.d_type support at configure time
---

diff --git a/06/a48cda76f584975c8d4c8cfbfbb6bc7097c225 b/06/a48cda76f584975c8d4c8cfbfbb6bc7097c225
new file mode 100644
index 000000000..566e8cf8a
--- /dev/null
+++ b/06/a48cda76f584975c8d4c8cfbfbb6bc7097c225
@@ -0,0 +1,67 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 17325431FBD
+	for <notmuch@notmuchmail.org>; Wed, 12 Feb 2014 22:55:31 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 3mLiRITeP7rm for <notmuch@notmuchmail.org>;
+	Wed, 12 Feb 2014 22:55:26 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 39472431FAE
+	for <notmuch@notmuchmail.org>; Wed, 12 Feb 2014 22:55:26 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id D44401000FA;
+	Thu, 13 Feb 2014 08:55:19 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2] new: Detect dirent.d_type support at configure time
+In-Reply-To: <1392274259-19765-1-git-send-email-amdragon@mit.edu>
+References: <1392274259-19765-1-git-send-email-amdragon@mit.edu>
+User-Agent: Notmuch/0.17+69~g761b031 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Thu, 13 Feb 2014 08:55:19 +0200
+Message-ID: <m2y51f7b8o.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 13 Feb 2014 06:55:31 -0000
+
+On Thu, Feb 13 2014, Austin Clements <amdragon@MIT.EDU> wrote:
+
+> Support for dirent.d_type is OS-specific.  Previously, we used
+> _DIRENT_HAVE_D_TYPE to detect support for this, but this is apparently
+> a glic-ism (FreeBSD, for example, supports d_type, but does not define
+> this).  Since there's no cross-platform way to detect support for
+> dirent.d_type, detect it using a test compile at configure time.
+> ---
+> This is a trivial rebase of
+> id:1385262952-29240-1-git-send-email-amdragon@mit.edu, which I
+> apparently never got around to sending.  Tomi and Jani checked off v1
+> of this patch, so I'm marking it ready.
+
+Looks good. Applies cleanly. Tests pass.
+
+Tomi
+