From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Wed, 10 Feb 2016 16:39:05 +0000 (+1900)
Subject: Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9681ca81fbe5edb2c92cb224a38a6b61783a1bdc;p=notmuch-archives.git

Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available
---

diff --git a/7f/3c1d4fb2175dd62de1c3e3d1450ceb0afe71a0 b/7f/3c1d4fb2175dd62de1c3e3d1450ceb0afe71a0
new file mode 100644
index 000000000..f3a62e1a9
--- /dev/null
+++ b/7f/3c1d4fb2175dd62de1c3e3d1450ceb0afe71a0
@@ -0,0 +1,74 @@
+Return-Path: <dkg@fifthhorseman.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id EE3E96DE179F
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 08:39:11 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.017
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.017 tagged_above=-999 required=5
+ tests=[AWL=-0.017] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 474BsAD9_yoN for <notmuch@notmuchmail.org>;
+ Wed, 10 Feb 2016 08:39:06 -0800 (PST)
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])
+ by arlo.cworth.org (Postfix) with ESMTP id 17B606DE1104
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 08:39:06 -0800 (PST)
+Received: from fifthhorseman.net (unknown [38.109.115.130])
+ by che.mayfirst.org (Postfix) with ESMTPSA id C5133F997;
+ Wed, 10 Feb 2016 11:39:03 -0500 (EST)
+Received: by fifthhorseman.net (Postfix, from userid 1000)
+ id 7AF832017F; Wed, 10 Feb 2016 11:39:05 -0500 (EST)
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
+To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available
+In-Reply-To: <87lh6svl0b.fsf@maritornes.cs.unb.ca>
+References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>
+ <1454272801-23623-7-git-send-email-dkg@fifthhorseman.net>
+ <87lh6svl0b.fsf@maritornes.cs.unb.ca>
+User-Agent: Notmuch/0.21+72~gd8c4f1c (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Wed, 10 Feb 2016 11:39:05 -0500
+Message-ID: <874mdgo6za.fsf@alice.fifthhorseman.net>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 10 Feb 2016 16:39:12 -0000
+
+On Wed 2016-02-10 06:54:12 -0500, David Bremner wrote:
+> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
+>
+>>  
+>> +# choose the preferred GnuPG binary:
+>> +if command -v gpg2 > /dev/null; then
+>> +    GPG=gpg2
+>> +else
+>> +    GPG=gpg
+>> +fi
+>
+> It feels like this should maybe be in configure, to centralize the choice
+> of GPG default. At least, that would be consistent with python / python2
+
+I'm not sure what to do here.  Ultimately, i don't want there to be a
+choice because i plan on having /usr/bin/gpg provided by gpg2, so this
+will all be moot.
+
+So i'm not inclined to spend much more time/engineering effort on it,
+but if someone wants to propose moving these choices into configure, i'd
+be willing to review.
+
+   --dkg