From: David Bremner <david@tethera.net>
Date: Sun, 19 May 2013 11:31:46 +0000 (+2100)
Subject: use of flet in notmuch-emacs
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=95210e63cb02bec6243243ca729938c5ae7efd77;p=notmuch-archives.git

use of flet in notmuch-emacs
---

diff --git a/27/457a84dcc419253d936c50e4ffcb14d14ad2cb b/27/457a84dcc419253d936c50e4ffcb14d14ad2cb
new file mode 100644
index 000000000..6cca9189b
--- /dev/null
+++ b/27/457a84dcc419253d936c50e4ffcb14d14ad2cb
@@ -0,0 +1,78 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 13677431FBC
+	for <notmuch@notmuchmail.org>; Sun, 19 May 2013 04:32:03 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: -2.3
+X-Spam-Level: 
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
+	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 717hULG-74Ve for <notmuch@notmuchmail.org>;
+	Sun, 19 May 2013 04:31:55 -0700 (PDT)
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
+	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 5AF6E431FB6
+	for <notmuch@notmuchmail.org>; Sun, 19 May 2013 04:31:55 -0700 (PDT)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4JBVswU016378
+	for <notmuch@notmuchmail.org>; Sun, 19 May 2013 08:31:54 -0300
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.82.78] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1Ue1qC-00034W-8u; Sun, 19 May 2013 08:31:54 -0300
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1Ue1q6-0006NI-La; Sun, 19 May 2013 08:31:46 -0300
+From: David Bremner <david@tethera.net>
+To: "Notmuch Mail List" <notmuch@notmuchmail.org>
+Subject: use of flet in notmuch-emacs
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 19 May 2013 08:31:46 -0300
+Message-ID: <87vc6fjjdp.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 19 May 2013 11:32:03 -0000
+
+
+Today I noticed
+
+,----
+| emacs --quick --directory emacs -batch -f batch-byte-compile emacs/notmuch-show.el
+| 
+| In notmuch-show-view-part:
+| emacs/notmuch-show.el:541:22:Warning: `flet' is an obsolete macro (as of
+|     24.3); use either `cl-flet' or `cl-letf'.
+`----
+
+Chatter on #emacs suggests that cl-flet is not in fact a replacement for
+our use case since it does not do dynamic binding. I'm not really 100%
+sure what the best plan is, but the old definition of flet is available
+at
+
+        https://github.com/sigma/el-x/blob/master/lisp/dflet.el
+
+d
+
+