From: Charles Celerier Date: Thu, 8 May 2014 15:00:07 +0000 (+2000) Subject: Re: [PATCH 2/5] configure, test: Added variables for paths to true and false. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=94aeaa9a812e778b4b7fb61ed52650372ffa82eb;p=notmuch-archives.git Re: [PATCH 2/5] configure, test: Added variables for paths to true and false. --- diff --git a/9d/5700733de76d500988a5e839767a4d4ccd9c81 b/9d/5700733de76d500988a5e839767a4d4ccd9c81 new file mode 100644 index 000000000..a090cfb3e --- /dev/null +++ b/9d/5700733de76d500988a5e839767a4d4ccd9c81 @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 69003431FBF + for ; Thu, 8 May 2014 08:00:20 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xqmVuDN3wHIE for ; + Thu, 8 May 2014 08:00:12 -0700 (PDT) +Received: from smtp1.cs.Stanford.EDU (smtp1.cs.Stanford.EDU [171.64.64.25]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 868AD431FAE + for ; Thu, 8 May 2014 08:00:12 -0700 (PDT) +Received: from c-24-11-133-78.hsd1.sc.comcast.net ([24.11.133.78] + helo=jane.lan) + by smtp1.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128) + (Exim 4.80.1) (envelope-from ) + id 1WiPnt-0004pf-2D; Thu, 08 May 2014 08:00:09 -0700 +From: Charles Celerier +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/5] configure, + test: Added variables for paths to true and false. +In-Reply-To: <87fvkkv4bc.fsf@maritornes.cs.unb.ca> +References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu> + <1399395748-44920-2-git-send-email-cceleri@cs.stanford.edu> + <1399395748-44920-3-git-send-email-cceleri@cs.stanford.edu> + <87fvkkv4bc.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18~rc0+32~gd5092c2 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-apple-darwin13.1.0) +Date: Thu, 08 May 2014 11:00:07 -0400 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-Scan-Signature: 6214ac49f2cb083a0c8190805312a710 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 08 May 2014 15:00:20 -0000 + +--=-=-= +Content-Type: text/plain + +David Bremner writes: + +> Charles Celerier writes: +> +>> The path to true may not be the same on all platforms (e.g. on Mac OS X +>> it is /usr/bin/true), so the hard-coded path of /bin/true is not +>> portable. This is resolved by adding a step to the configure script to +>> locate the path of true and to use the TRUE variable wherever /bin/true +>> was needed. The same was done for false. +> +> Does this really need a configure script variable? It seems like +> overkill. + +I will be the first too admit that I do not know much about configure +scripts, but adding a TRUE variable seemed straightforward. The problem +is that you want to make softlinks for test/have-man and +test/have-compact for how they are used in tests T010-help-test and +T020-compact; making softlinks requires full paths. You could use +`$(which true)` in test/Makefile.local, but I felt the code repetition +there was unecessary since you could just create a TRUE variable in the +configure script. An alternative is to change the tests so that the +location of true (and false) is no longer an issue. + +chuck + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG/MacGPG2 v2.0.22 (Darwin) + +iQEcBAEBAgAGBQJTa5v3AAoJEOjk698fDjuASPEH/jBF3OMlZD5VHprNSm0J1Wfv +qqnGPHPNTaDl2MRFY7EhPJ5rtuava3IEFP1iQLTeEvqwLYmQmYk/2xZj+Z7DnCX/ +C9B4QCT76j1Pq2I1N4x7cBvlSQvJZzPchUeQrMu8pV5kib9Zvrppdm/WHUkZeJPJ +u+juPfbW/lsntcWEGPt35yW3LyH0VH5fnuTBdbau6K+cRaKxVelBKIDN6kot1CBQ +lI9Hjm3E5m0IJSAAEzW2aAKMb+8J2dklsJwgohTl42eHlU/cVcShOp/wNhF2vJyM +4cZeJEccigiLXEpmwpV4zBmDHfW/jWTN1zDOhi+HG0x6IA/Ku06u6WpyWMB7rGc= +=CZ4Q +-----END PGP SIGNATURE----- +--=-=-=--