From: Alexandra Ellwood <lxs@mit.edu>
Date: Fri, 30 May 2008 18:01:09 +0000 (+0000)
Subject: signed vs unsigned char * warnings in kdb_xdr.c
X-Git-Tag: krb5-1.7-alpha1~676
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=94ae54563eeea9c657eb603651d0d32e535c7a23;p=krb5.git

signed vs unsigned char * warnings in kdb_xdr.c

load and store functions in k5-platform.h take an unsigned char *, whereas
kdb_xdr.c was using a char * for decoding.  This resulted in pages of warnings
in the parsing code.  Switched to using an unsigned char * and cast in the
couple places where a char * is needed.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20343 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/plugins/kdb/db2/kdb_xdr.c b/src/plugins/kdb/db2/kdb_xdr.c
index 396350d76..f00131a00 100644
--- a/src/plugins/kdb/db2/kdb_xdr.c
+++ b/src/plugins/kdb/db2/kdb_xdr.c
@@ -65,7 +65,7 @@ krb5_encode_princ_contents(context, content, entry)
     int 		  i, j;
     unsigned int	  unparse_princ_size;
     char 		* unparse_princ;
-    char		* nextloc;
+    unsigned char	* nextloc;
     krb5_tl_data	* tl_data;
     krb5_error_code 	  retval;
     krb5_int16		  psize16;
@@ -128,7 +128,7 @@ krb5_encode_princ_contents(context, content, entry)
      * Now we go through entry again, this time copying data 
      * These first entries are always saved regardless of version
      */
-    nextloc = content->data;
+    nextloc = (unsigned char *)content->data;
 
 	/* Base Length */
     krb5_kdb_encode_int16(entry->len, nextloc);
@@ -250,7 +250,7 @@ krb5_decode_princ_contents(context, content, entry)
     krb5_db_entry 	* entry;
 {
     int			  sizeleft, i;
-    char 		* nextloc;
+    unsigned char 	* nextloc;
     krb5_tl_data       ** tl_data;
     krb5_int16		  i16;
 
@@ -269,7 +269,7 @@ krb5_decode_princ_contents(context, content, entry)
      */
 
     /* First do the easy stuff */
-    nextloc = content->data;
+    nextloc = (unsigned char *)content->data;
     sizeleft = content->length;
     if ((sizeleft -= KRB5_KDB_V1_BASE_LENGTH) < 0) 
 	return KRB5_KDB_TRUNCATED_RECORD;
@@ -349,9 +349,9 @@ krb5_decode_princ_contents(context, content, entry)
     i = (int) i16;
     nextloc += 2;
 
-    if ((retval = krb5_parse_name(context, nextloc, &(entry->princ))))
+    if ((retval = krb5_parse_name(context, (char *)nextloc, &(entry->princ))))
 	goto error_out;
-    if (((size_t) i != (strlen(nextloc) + 1)) || (sizeleft < i)) {
+    if (((size_t) i != (strlen((char *)nextloc) + 1)) || (sizeleft < i)) {
 	retval = KRB5_KDB_TRUNCATED_RECORD;
 	goto error_out;
     }