From: Mark Walters Date: Sat, 5 Mar 2016 11:26:54 +0000 (+0000) Subject: Re: use font-face instead of explicit colouring X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9460ec49fe2ed83944cf574fb331f90723cf3a47;p=notmuch-archives.git Re: use font-face instead of explicit colouring --- diff --git a/a6/dc6d31a17f7cf4ef1148baa97fd1fc1392658b b/a6/dc6d31a17f7cf4ef1148baa97fd1fc1392658b new file mode 100644 index 000000000..fc4faacef --- /dev/null +++ b/a6/dc6d31a17f7cf4ef1148baa97fd1fc1392658b @@ -0,0 +1,168 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 4849A6DE11EC + for ; Sat, 5 Mar 2016 03:27:00 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.297 +X-Spam-Level: +X-Spam-Status: No, score=-0.297 tagged_above=-999 required=5 tests=[AWL=0.273, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id mfb5xdiiJ6Ix for ; + Sat, 5 Mar 2016 03:26:58 -0800 (PST) +Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com + [74.125.82.41]) by arlo.cworth.org (Postfix) with ESMTPS id 920136DE1003 for + ; Sat, 5 Mar 2016 03:26:57 -0800 (PST) +Received: by mail-wm0-f41.google.com with SMTP id n186so23841909wmn.1 + for ; Sat, 05 Mar 2016 03:26:57 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version; + bh=Jwo2sOZKHvGxhypIl2MVmVvVMNuLXPPeeoPsWHluoKU=; + b=lg3c2pSVesnz44SX8LsahiGT9SuBbUHGGpBrZpIZxWCTGRsQ9Lr4X7KcTWS1zVjjX6 + rX/lJEVlKAMrB1a9JUUPyqdX+SXebVkoyb8yn5Ke7yltf6c3jTlReDAYnrpNk4VPHIKP + VoDAe929vhVZfYJnOSqLKuCK+WR2D2Sf+2NjGsNQl5KvbpN9sliUNaXBVBKp8Ck5ZOV9 + msZveSDcDKKAug44+wOXZLFYwZyA9z/1TwhMjOoTd+8y+yFuk/lhAotoCPI2jN9Nr/sP + S+/3Frad5j3hWZJoHBvPwS6miLG8txXLD2yh6kmJv2WCrtm2H3vfITXNSEc+eRD4NdxM + OjyQ== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version; + bh=Jwo2sOZKHvGxhypIl2MVmVvVMNuLXPPeeoPsWHluoKU=; + b=jCLSvP4TrC/elynJjqfZ+p9y6Loezt2+04LEKigbB6fXHbfJGl1cFDNnQD5Jxa9eL6 + jHf3tfVHTc33ilwHmjbnMuxNoIR9dWuGvPGLaa9JI7PJ8DcK3iOmZm6EclAvra4Xf0ss + Ho3D8XMWB6uYgxGPISXz+/K9TzcnTYgSOUIeFfefokMwbXC4hr7MRMwUeCXI19ckeVyb + Ix7nmGRP+yOIxgSAwp3AjGSJIUNl4nyk2FqsmnmqjJdgLJW3k4mPLkia4/+UktKZXKvN + WjBKpV70NR0mv1uOr0pRm4fmYnVAtfXmlgpqbcesGeedn8GuZFJLdKmhOfkw/hJNCdnC + aqig== +X-Gm-Message-State: + AD7BkJL3fK944fLljw7Qxama9rvbgoBM2eNFvjiENVbXryNdCRxrX+gUqNkNmMi8BP0yGw== +X-Received: by 10.194.216.2 with SMTP id om2mr13262812wjc.164.1457177216238; + Sat, 05 Mar 2016 03:26:56 -0800 (PST) +Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) + by smtp.gmail.com with ESMTPSA id gg7sm7751075wjd.10.2016.03.05.03.26.55 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 05 Mar 2016 03:26:55 -0800 (PST) +From: Mark Walters +To: Sam Halliday +Cc: notmuch@notmuchmail.org +Subject: Re: use font-face instead of explicit colouring +In-Reply-To: + +References: <87mvqdmer2.fsf@gmail.com> <87k2lhmecn.fsf@gmail.com> + <87h9glb367.fsf@qmul.ac.uk> + +User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 05 Mar 2016 11:26:54 +0000 +Message-ID: <87egbpb1xd.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 Mar 2016 11:27:00 -0000 + + +Hi + +On Sat, 05 Mar 2016, Sam Halliday wrote: +> That's a shame. Having light/dark alternatives are OK as a workaround but +> it's a shame this can't just all be done with faces. I don't see why there +> needs to be a string to face lookup map, why not just put the string in the +> face name? + +If you did that how would you let a user customize it (I mean as a +defcustom, rather than setq in .emacs)? There is also a possible +question of dealing with tags with weird characters (eg spaces or +worse), so some form of quoting would be needed. + +It's not something I have interest in implementing, but I would be happy +to review patches doing this. Dme might also have some comments -- he +had a complete rewrite of the code dealing with the search format. + +Best wishes + +Mark + + + + + +> On 5 Mar 2016 11:00 a.m., "Mark Walters" wrote: +> +>> +>> Hi +>> +>> On Sat, 05 Mar 2016, Sam Halliday wrote: +>> > I should say that I am aware of the workaround, e.g. +>> > +>> > (setq +>> > notmuch-search-line-faces '(("unread" :weight bold) +>> > ("flagged" :inherit +>> 'font-lock-string-face))) +>> > +>> > but this must be applied per-user. If you removed this defcustom and had +>> > unread/flagged/other faces, then themes (such as darcula) would be able +>> > to provide sensible defaults out of the box. +>> +>> I am not sure I see how this would work without cluttering up the +>> customize options significantly. The notmuch-search-line-faces allows +>> selecting the face based on any tag (so for example I use different +>> colours for emails tagged "work", and tagged "waiting"). We could have +>> additional notmuch-search-line-unread-face which could then be used in +>> the above -- but now the user has two places to customize the same thing. +>> +>> How do you see this working? +>> +>> (We probably could make the default depend on light or dark theme to make +>> the default more usable.) +>> +>> Best wishes +>> +>> Mark +>> +>> > +>> > Sam Halliday writes: +>> > +>> >> [ text/plain ] +>> >> Hi, +>> >> +>> >> I use a dark theme and many of the colour choices of notmuch collide +>> >> with my theme. However, notmuch is explicitly adding information such as +>> >> "blue foreground" instead of using faces that I can customise. +>> >> +>> >> Could you please consider using faces instead of explicit colours? +>> >> +>> >> [ text/plain ] +>> >> +>> >> -- +>> >> Best regards, +>> >> Sam +>> >> [ signature.asc: application/pgp-signature ] +>> > +>> > -- +>> > Best regards, +>> > Sam +>> > _______________________________________________ +>> > notmuch mailing list +>> > notmuch@notmuchmail.org +>> > https://notmuchmail.org/mailman/listinfo/notmuch +>>