From: David Bremner <david@tethera.net>
Date: Fri, 12 Aug 2016 06:17:28 +0000 (+0900)
Subject: Re: [PATCH v4 02/16] Move crypto.c into libutil
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9369c94581ad196139d3a4314b0127351875f97d;p=notmuch-archives.git

Re: [PATCH v4 02/16] Move crypto.c into libutil
---

diff --git a/c0/9acaf712d6ac170b16aef98e5c20b7f3140a69 b/c0/9acaf712d6ac170b16aef98e5c20b7f3140a69
new file mode 100644
index 000000000..280e400eb
--- /dev/null
+++ b/c0/9acaf712d6ac170b16aef98e5c20b7f3140a69
@@ -0,0 +1,77 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 75DC16DE0926
+ for <notmuch@notmuchmail.org>; Thu, 11 Aug 2016 23:17:40 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.008
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.008 tagged_above=-999 required=5 tests=[AWL=0.003,
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id AiIIQJSqcdSU for <notmuch@notmuchmail.org>;
+ Thu, 11 Aug 2016 23:17:32 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 0A60D6DE091F
+ for <notmuch@notmuchmail.org>; Thu, 11 Aug 2016 23:17:31 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
+ (envelope-from <david@tethera.net>)
+ id 1bY5mq-0006tH-P3; Fri, 12 Aug 2016 02:17:44 -0400
+Received: (nullmailer pid 21013 invoked by uid 1000);
+ Fri, 12 Aug 2016 06:17:28 -0000
+From: David Bremner <david@tethera.net>
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v4 02/16] Move crypto.c into libutil
+In-Reply-To: <1467970047-8013-3-git-send-email-dkg@fifthhorseman.net>
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>
+ <1467970047-8013-3-git-send-email-dkg@fifthhorseman.net>
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Fri, 12 Aug 2016 15:17:28 +0900
+Message-ID: <874m6qqznr.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 12 Aug 2016 06:17:40 -0000
+
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
+> +++ b/util/crypto.c
+> @@ -0,0 +1,138 @@
+
+> +#include "notmuch.h"
+
+It feels wrong to me for a file in util/ to include notmuch.h.  It seems
+the same situation holds with search-path.h.  There it seems we use
+notmuch_bool_t (although I'm not convinced that's the right return
+type). If that's the only reason maybe we should either factor out the
+definition or just return ints.
+
+> +/* Create a PKCS7 context (GMime 2.6) */
+> +static notmuch_crypto_context_t *
+> +create_pkcs7_context (notmuch_crypto_t *crypto)
+> +{
+> +    notmuch_crypto_context_t *pkcs7ctx;
+
+I guess this is leftover, and causes the build failure.
+
+> +
+> +#include "notmuch.h"
+
+Same questions notmuch.h here.
+
+d