From: Jesse Rosenthal Date: Fri, 31 Oct 2014 18:04:50 +0000 (+2000) Subject: Re: [PATCH] test: Make gen-threads work with python3 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=931b438810aac4f9c2be8478f65625c6766cbae0;p=notmuch-archives.git Re: [PATCH] test: Make gen-threads work with python3 --- diff --git a/55/cf0c181c2910b5642ee4fc59446df8105001a1 b/55/cf0c181c2910b5642ee4fc59446df8105001a1 new file mode 100644 index 000000000..6e6c773fd --- /dev/null +++ b/55/cf0c181c2910b5642ee4fc59446df8105001a1 @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 53675431FBC + for ; Fri, 31 Oct 2014 12:05:02 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nUauVPg7SM9G for ; + Fri, 31 Oct 2014 12:04:54 -0700 (PDT) +X-Greylist: delayed 3602 seconds by postgrey-1.32 at olra; + Fri, 31 Oct 2014 12:04:54 PDT +Received: from smtpauth.johnshopkins.edu (smtpauth.johnshopkins.edu + [128.220.229.147]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 91FCE431FAF + for ; Fri, 31 Oct 2014 12:04:54 -0700 (PDT) +X-IronPort-AV: E=Sophos;i="5.07,295,1413259200"; d="scan'208";a="17204995" +Received: from guppy.hwcampus.jhu.edu (HELO localhost) ([10.161.32.234]) + by IPMTW1.johnshopkins.edu with ESMTP/TLS/AES128-SHA; + 31 Oct 2014 14:04:51 -0400 +From: Jesse Rosenthal +To: "W. Trevor King" +Subject: Re: [PATCH] test: Make gen-threads work with python3 +In-Reply-To: <20141031174153.GQ15443@odin.tremily.us> +References: <1414776805-30000-1-git-send-email-jrosenthal@jhu.edu> + <20141031174153.GQ15443@odin.tremily.us> +User-Agent: Notmuch/0.18.2+156~g1f413d7 (http://notmuchmail.org) Emacs/24.4.1 + (i686-pc-linux-gnu) +Date: Fri, 31 Oct 2014 14:04:50 -0400 +Message-ID: <87bnosdsjh.fsf@jhu.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 31 Oct 2014 19:05:02 -0000 + +"W. Trevor King" writes: + +> On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote: +>> We instead initalize the dictionary using the dict comprehension and +>> then update it with the values from the tree. This will work with +>> both python2 and python3. +> +> Dict comprehensions are new in 2.7 [1,2], so this drops support for +> systems where =E2=80=98python=E2=80=99 means =E2=80=98python2.6=E2=80=99.= + Personally, I'm fine with +> that, but I thought I'd point it out in case 2.6 users wanted to push +> back ;). + +The comprehension was already in the previous version, so I figured that +people were already cool with 2.7+. + +>> - +>> import sys +> +> Why remove this blank line? + +Oops -- I had put in a print_function import from __future__ for +testing. Must have lost the line when I took it back out. Is it worth +resubmitting to fix that?