From: David Bremner Date: Thu, 19 Feb 2015 18:17:41 +0000 (+0100) Subject: Re: [PATCH] configure: consistent command -v usage X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=93140a421931e412146f53206ab12aba9b5a0f18;p=notmuch-archives.git Re: [PATCH] configure: consistent command -v usage --- diff --git a/48/70d8ea7f0182ba28a7d84bf09f8c291092dfcd b/48/70d8ea7f0182ba28a7d84bf09f8c291092dfcd new file mode 100644 index 000000000..945cd67b7 --- /dev/null +++ b/48/70d8ea7f0182ba28a7d84bf09f8c291092dfcd @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1939B429E54 + for ; Thu, 19 Feb 2015 10:30:24 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id f1dgmnQT1+p9 for ; + Thu, 19 Feb 2015 10:30:20 -0800 (PST) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CBF26429E4B + for ; Thu, 19 Feb 2015 10:30:20 -0800 (PST) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1YOVff-0004aQ-I3; Thu, 19 Feb 2015 18:17:55 +0000 +Received: (nullmailer pid 13749 invoked by uid 1000); Thu, 19 Feb 2015 + 18:17:41 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] configure: consistent command -v usage +In-Reply-To: <1424271241-11885-1-git-send-email-tomi.ollila@iki.fi> +References: <1424271241-11885-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.19+48~gb74ed1c (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 19 Feb 2015 19:17:41 +0100 +Message-ID: <87a909kbp6.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 19 Feb 2015 18:30:24 -0000 + +Tomi Ollila writes: + +> When the shell builtin `command -v` operates normally, it either +> prints the path of the arg given to it and returns zero -- or it +> returns nonzero and prints nothing. +> In abnormal situations something might be printed to stderr and +> in that case we want to know about it; therefore the used +> command -v stderr redirections to /dev/null have been removed. +> +> The `hash` (builtin) command in ksh returns zero even the arg +> given to is is not found in path. For that and for consistency +> the one appearance of it has been converted to `command -v`. +> --- +> +> marked trivial +> + +and pushed + +d