From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 23 Jun 2015 21:14:02 +0000 (+0300)
Subject: Re: [PATCH] emacs: tree: mark read change
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=92140ebb6bc44ca4e79e1e41a2e1e2a0c16bf56c;p=notmuch-archives.git

Re: [PATCH] emacs: tree: mark read change
---

diff --git a/a9/c75be38b6b715164486e5ddec718d55ccf17cb b/a9/c75be38b6b715164486e5ddec718d55ccf17cb
new file mode 100644
index 000000000..21d660e7e
--- /dev/null
+++ b/a9/c75be38b6b715164486e5ddec718d55ccf17cb
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 1AE416DE0298
+ for <notmuch@notmuchmail.org>; Tue, 23 Jun 2015 14:14:28 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.968
+X-Spam-Level: 
+X-Spam-Status: No, score=0.968 tagged_above=-999 required=5 tests=[AWL=0.316, 
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id iNlF9P8r2IYX for <notmuch@notmuchmail.org>;
+ Tue, 23 Jun 2015 14:14:25 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 878B06DE028A
+ for <notmuch@notmuchmail.org>; Tue, 23 Jun 2015 14:14:25 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id B38D9100046;
+ Wed, 24 Jun 2015 00:14:02 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>,
+ Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] emacs: tree: mark read change
+In-Reply-To: <87si9iyxn9.fsf@maritornes.cs.unb.ca>
+References: <1433843467-32398-1-git-send-email-markwalters1009@gmail.com>
+ <87si9iyxn9.fsf@maritornes.cs.unb.ca>
+User-Agent: Notmuch/0.20.1+30~g467da49 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 24 Jun 2015 00:14:02 +0300
+Message-ID: <m2616eb011.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 23 Jun 2015 21:14:28 -0000
+
+On Tue, Jun 23 2015, David Bremner <david@tethera.net> wrote:
+
+> Mark Walters <markwalters1009@gmail.com> writes:
+>
+>> The mark read code for tree mode did not get updated in the recent
+>> changes. This updates it to match. Since the user can customize the
+>> mark read logic we just call the show logic in the message pane.
+>> ---
+>>
+>> An alternative would be to mark any message explicitly viewed in
+>> tree-mode as read. That would be simpler but I think this is better as
+>> it deals with user customized mark read functions -- for example if
+>> the user has a customized function that only marks a message read if
+>> the whole message is viewed then this version will do the same in tree
+>> mode.
+>
+> At first I was leery of the chaining of hooks, but now that I
+> noticed/experienced the bug, it makes more sense to me.  I'm considering
+> rolling a bug fix release with this (I imagine the bug is pretty
+> annoying for people using only notmuch-tree), so I'd like a bit more
+> feedback before merging it.
+
+>From code point of view it looks good to me.
+
+Tomi
+
+>
+> d