From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Tue, 19 Jan 2010 06:37:14 +0000 (-0500)
Subject: added a few more FIXMEs to check_service_name()
X-Git-Tag: monkeysphere_0.28~12
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=91fdd7dab0b3ea6dba4cc6f12083cba420610725;p=monkeysphere.git

added a few more FIXMEs to check_service_name()
---

diff --git a/src/monkeysphere-host b/src/monkeysphere-host
index a90ab15..884c1b7 100755
--- a/src/monkeysphere-host
+++ b/src/monkeysphere-host
@@ -110,6 +110,11 @@ update_pgp_pub_file() {
 # all-number (e.g. ssh://666.666), which are technically not allowed
 # (though some exist on the 'net, apparently)
 
+# FIXME: this will probably misbehave if raw IP addresses are provided,
+# either IPv4 or IPv6 using the bracket notation.
+
+# FIXME: this doesn't address the use of hashed User IDs.
+
 check_service_name() {
     local name="$1"
     local errs=""