From: Jani Nikula Date: Sun, 2 Feb 2014 19:32:53 +0000 (+0200) Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=91329149eda21ca52ed91bae4ba201287896df43;p=notmuch-archives.git Re: [PATCH v2 0/7] lib: replace the message header parser with gmime --- diff --git a/ce/b2fc0bdca51c4cf937631eb06a55b2deaeda99 b/ce/b2fc0bdca51c4cf937631eb06a55b2deaeda99 new file mode 100644 index 000000000..f02ae8136 --- /dev/null +++ b/ce/b2fc0bdca51c4cf937631eb06a55b2deaeda99 @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 44179431FBD + for ; Sun, 2 Feb 2014 11:33:06 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id eLmw0EupP8QC for ; + Sun, 2 Feb 2014 11:33:01 -0800 (PST) +Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com + [209.85.215.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A8EAD431FBC + for ; Sun, 2 Feb 2014 11:33:01 -0800 (PST) +Received: by mail-ea0-f172.google.com with SMTP id l9so1943207eaj.3 + for ; Sun, 02 Feb 2014 11:32:57 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=IJzKxAJjZxwzRu5Xo9QI2B+jlJZzSkUXoabpHTG4hRQ=; + b=ctoYXcZ02V7enw7j1r2nCfQMk7ILdaBa5tPiLNtey3tQyQJ2AeMLVNIn3K2S9GmsHG + b1V78nKzowcJZ0Z8DVxeJklsrNya5cLCoUIkpKBz4JnK14a+bzqCvEIkp0UeEA23aiEY + Tl8UKrw4q/pcF3ggWpuO10lMfa8JtN6rSIMgXcZq6Km2/Gtb+yLBpHjLyXAanvPcQ3a0 + g+CtxKdQKesm9QRMzfxM5SQhwmdY73xjDwM+olo/9GfmABYZu/COHYmRA6rmMWHMNKH6 + YbLT8hZw7f+AyYxzzbnRZofKbrEcv7xHRqGkWaiohgVNzIPSTE3P74EfG4KvbKQC0iAf + ppQQ== +X-Gm-Message-State: + ALoCoQm5bEWi5iXZgedlj/RXOS5Bq7K2O/4t3BhkUGBTUhSr0xfLmzIuQzz87zgYjhlwiSHHQB8l +X-Received: by 10.14.183.132 with SMTP id q4mr2967716eem.91.1391369577830; + Sun, 02 Feb 2014 11:32:57 -0800 (PST) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) + by mx.google.com with ESMTPSA id m1sm65327064een.7.2014.02.02.11.32.55 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 02 Feb 2014 11:32:56 -0800 (PST) +From: Jani Nikula +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime +In-Reply-To: <874n4hqt3m.fsf@qmul.ac.uk> +References: <874n4hqt3m.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.17+44~ge3b4cd9 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Feb 2014 21:32:53 +0200 +Message-ID: <87y51twbru.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Feb 2014 19:33:06 -0000 + +On Sun, 02 Feb 2014, Mark Walters wrote: +> Patches 1-4 basically LGTM but patch 1 needs to be rebased since all the +> tests were renamed. I have a couple of minor comments on patches 2 and 3 +> that I will send separately. + +Thanks Mark. I've addressed all your comments, and will post v3 after +I've tested it a bit. + +BR, +Jani.