From: Tay Ray Chuan Date: Mon, 19 Apr 2010 14:46:43 +0000 (+0800) Subject: http.c::new_http_pack_request: do away with the temp variable filename X-Git-Tag: v1.7.2-rc0~118^2 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=90d05713575ea6ed21d05228bcda8461f7b28ccf;p=git.git http.c::new_http_pack_request: do away with the temp variable filename Now that the temporary variable char *filename is only used in one place, do away with it and just call sha1_pack_name() directly. Signed-off-by: Tay Ray Chuan Acked-by: Shawn O. Pearce Signed-off-by: Junio C Hamano --- diff --git a/http.c b/http.c index 0813c9ecd..e41fcc380 100644 --- a/http.c +++ b/http.c @@ -1077,7 +1077,6 @@ int finish_http_pack_request(struct http_pack_request *preq) struct http_pack_request *new_http_pack_request( struct packed_git *target, const char *base_url) { - char *filename; long prev_posn = 0; char range[RANGE_HEADER_SIZE]; struct strbuf buf = STRBUF_INIT; @@ -1092,8 +1091,8 @@ struct http_pack_request *new_http_pack_request( sha1_to_hex(target->sha1)); preq->url = strbuf_detach(&buf, NULL); - filename = sha1_pack_name(target->sha1); - snprintf(preq->tmpfile, sizeof(preq->tmpfile), "%s.temp", filename); + snprintf(preq->tmpfile, sizeof(preq->tmpfile), "%s.temp", + sha1_pack_name(target->sha1)); preq->packfile = fopen(preq->tmpfile, "a"); if (!preq->packfile) { error("Unable to open local file %s for pack",