From: Tomi Ollila Date: Mon, 6 Oct 2014 18:28:55 +0000 (+0300) Subject: Re: [PATCH] VIM: Make an option to save sent mail locally X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8fc5373eb825a5b4fc3329aad3f5ecc58f7c39a9;p=notmuch-archives.git Re: [PATCH] VIM: Make an option to save sent mail locally --- diff --git a/35/b35169579e30b84befdcca51063652197c93d4 b/35/b35169579e30b84befdcca51063652197c93d4 new file mode 100644 index 000000000..7ae720e91 --- /dev/null +++ b/35/b35169579e30b84befdcca51063652197c93d4 @@ -0,0 +1,143 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 30119431FBD + for ; Mon, 6 Oct 2014 11:29:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id IkUruiC2xLFv for ; + Mon, 6 Oct 2014 11:29:14 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 78189431FAE + for ; Mon, 6 Oct 2014 11:29:14 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 0DC3710009D; + Mon, 6 Oct 2014 21:28:56 +0300 (EEST) +From: Tomi Ollila +To: Ian Main , notmuch@notmuchmail.org +Subject: Re: [PATCH] VIM: Make an option to save sent mail locally +In-Reply-To: <1412619036-29203-1-git-send-email-imain@stemwinder.org> +References: <1412617904-27252-1-git-send-email-imain@stemwinder.org> + <1412619036-29203-1-git-send-email-imain@stemwinder.org> +User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 Oct 2014 18:29:22 -0000 + +On Mon, Oct 06 2014, Ian Main wrote: + +> Add an option to use 'notmuch insert' to save your sent mail. +> --- +> +> Add -inbox as well. +> +> vim/notmuch.vim | 17 +++++++++++++++++ +> 1 file changed, 17 insertions(+) +> +> diff --git a/vim/notmuch.vim b/vim/notmuch.vim +> index 331e930..a9044c4 100644 +> --- a/vim/notmuch.vim +> +++ b/vim/notmuch.vim +> @@ -58,6 +58,7 @@ let s:notmuch_date_format_default = '%d.%m.%y' +> let s:notmuch_datetime_format_default = '%d.%m.%y %H:%M:%S' +> let s:notmuch_reader_default = 'mutt -f %s' +> let s:notmuch_sendmail_default = 'sendmail' +> +let s:notmuch_save_sent_locally_default = 1 +> let s:notmuch_folders_count_threads_default = 0 +> +> function! s:new_file_buffer(type, fname) +> @@ -108,6 +109,18 @@ EOF +> echohl None +> return +> endif + +AFAIU looks mmm. readable ;) + +> + +> + if g:notmuch_save_sent_locally +> + let out = system('cat ' . fname . ' | notmuch insert --create-folder --folder=Sent +sent -unread -inbox') + +as this is (looks like) shell invocation, this could be in format + +let out = system('notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname) + +or even + +let out = system('exec notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname) + +(well, the latter would be out of the status quo) + +Ok, I looked a bit into the notmuch.vim -code, and noticed sometimes +system() command lines use "notmuch" and sometimes g:notmuch_cmd +-- I think the latter should be used in new code and the previous ones +should be fixed. + +i.e. system ( g:notmuch_cmd . ' insert ... ' < . fname) + +Totally untested from my part... + +When the change alike this lands to the notmuch repository this needs NEWS +item which informs that from now sent mails are notmuch-inserted to +user's mail store (as this seems to be the default...) -- well, let's see +that when there are real reviewers (i.e. those who are interested to and can +test this). + + +Tomi + + +> + let err = v:shell_error +> + if err +> + echohl Error +> + echo 'Eeek! unable to save sent mail' +> + echo out +> + echohl None +> + return +> + endif +> + endif +> call delete(fname) +> echo 'Mail sent successfully.' +> call s:kill_this_buffer() +> @@ -388,6 +401,10 @@ endfunction +> "" root +> +> function! s:set_defaults() +> + if !exists('g:notmuch_save_sent_locally') +> + let g:notmuch_save_sent_locally = s:notmuch_save_sent_locally_default +> + endif +> + +> if !exists('g:notmuch_date_format') +> if exists('g:notmuch_rb_date_format') +> let g:notmuch_date_format = g:notmuch_rb_date_format +> -- +> 1.9.3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch