From: David Bremner <david@tethera.net>
Date: Wed, 1 Apr 2015 07:09:22 +0000 (+0200)
Subject: Re: [PATCH] test/thread-order: more robust loop exit in case of broken	input
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8d80c6d977af3ca8444aa1421c3c3e641d2d2efd;p=notmuch-archives.git

Re: [PATCH] test/thread-order: more robust loop exit in case of broken	input
---

diff --git a/2c/dc982b35d0283c31578c07d0fef925807921dc b/2c/dc982b35d0283c31578c07d0fef925807921dc
new file mode 100644
index 000000000..e3fc2964d
--- /dev/null
+++ b/2c/dc982b35d0283c31578c07d0fef925807921dc
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id F02086DE19A1
+ for <notmuch@notmuchmail.org>; Fri,  3 Apr 2015 16:04:23 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 1.218
+X-Spam-Level: *
+X-Spam-Status: No, score=1.218 tagged_above=-999 required=5 tests=[AWL=0.414, 
+ DATE_IN_PAST_12_24=0.804] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 9SaogSyDxXe7 for <notmuch@notmuchmail.org>;
+ Fri,  3 Apr 2015 16:04:22 -0700 (PDT)
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
+ [87.98.215.224])
+ by arlo.cworth.org (Postfix) with ESMTPS id 3532B6DE1994
+ for <notmuch@notmuchmail.org>; Fri,  3 Apr 2015 16:04:22 -0700 (PDT)
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
+ 4.80) (envelope-from <david@tethera.net>)
+ id 1YdXGo-0003TN-VT; Thu, 02 Apr 2015 05:02:23 +0000
+Received: (nullmailer pid 1646 invoked by uid 1000); Wed, 01 Apr 2015
+ 07:09:22 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] test/thread-order: more robust loop exit in case of
+ broken	input
+In-Reply-To: <1427643036-7171-1-git-send-email-tomi.ollila@iki.fi>
+References: <1427643036-7171-1-git-send-email-tomi.ollila@iki.fi>
+User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1
+ (x86_64-pc-linux-gnu)
+Date: Wed, 01 Apr 2015 09:09:22 +0200
+Message-ID: <874mp0495p.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: tomi.ollila@iki.fi
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 03 Apr 2015 23:04:24 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+> When creating $THREADS data it may end of not having 'None' at all
+> or the numbers in line output yields a loop.
+>
+> To avoid loop the value in current array index is set to 'None'
+> so that if the same item is reached again the loop will end.
+>
+> Also empty string as next array index will end the loop.
+
+lgtm
+
+d