From: Junio C Hamano <junkio@cox.net>
Date: Tue, 31 Oct 2006 00:07:54 +0000 (-0800)
Subject: quote.c: ensure the same quoting across platforms.
X-Git-Tag: v1.4.3.4~12
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8d63d95f297446fe110ea76d350ae15676e2ed54;p=git.git

quote.c: ensure the same quoting across platforms.

We read a byte from "char *" and compared it with ' ' to decide
if it needs quoting to protect textual output.  With a platform
where char is unsigned char that would give different result.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/quote.c b/quote.c
index e3a4d4aef..dc5c0a771 100644
--- a/quote.c
+++ b/quote.c
@@ -209,7 +209,7 @@ static int quote_c_style_counted(const char *name, int namelen,
 		if (!ch)
 			break;
 		if ((ch < ' ') || (ch == '"') || (ch == '\\') ||
-		    (ch == 0177)) {
+		    (ch >= 0177)) {
 			needquote = 1;
 			switch (ch) {
 			case '\a': EMITQ(); ch = 'a'; break;