From: Jani Nikula Date: Thu, 1 Jan 2015 14:33:45 +0000 (+0200) Subject: Re: [PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8c5a0d736bca6f285d99abc9c9e9bd6abc186487;p=notmuch-archives.git Re: [PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only --- diff --git a/04/e6e58b78b5baf86353328bc96b63e75134607c b/04/e6e58b78b5baf86353328bc96b63e75134607c new file mode 100644 index 000000000..c6d40edf5 --- /dev/null +++ b/04/e6e58b78b5baf86353328bc96b63e75134607c @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3A506431FC7 + for ; Thu, 1 Jan 2015 06:33:43 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id NwmtLgcBZOke for ; + Thu, 1 Jan 2015 06:33:40 -0800 (PST) +Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com + [209.85.212.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C6C9E431FC0 + for ; Thu, 1 Jan 2015 06:33:39 -0800 (PST) +Received: by mail-wi0-f176.google.com with SMTP id ex7so26721774wid.9 + for ; Thu, 01 Jan 2015 06:33:37 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=a/oeadlxsCLgiuC4LBmYTIx/fhXwtm7ZpxraVkm2poI=; + b=J6YK3Ft6dNwMVhvSUP5jHKT06EwXzMTKY3QKZkci3sMUGPmmfDNMgCx4+snJLtYkt8 + v9tqkuvBypoPO0E6vLXrINXKU527tMoX42sRCPCyhOj3/9YZIJqdOOpaKe0aX6gTufpw + YJ29arWo+N7cRQiPaNJJ0pzQJR9/LqU/q4mQOu2pX5bIHnusqEd5gmh8mYmDMFRPus5L + 5aB8oV142U1WNkR29kggJJpDuk+tzYG9ySfg2+Lg8uwHYsrp/uSv5u3OLkGVJhd+dVYH + 69s/FvS0KqYya62XcBuTl0OnZOR/gA6vSadRXsilbw2p5eIScOoyrHp3+A5G1zQUbWaV + EUcA== +X-Gm-Message-State: + ALoCoQkxt7P2B5MSCHk10IdcVlECclE9UUFxf23i6dVOQE0Uv5SpdFtFgPHzpoGsgD2OMozpLlhy +X-Received: by 10.180.19.193 with SMTP id h1mr124126972wie.10.1420122817549; + Thu, 01 Jan 2015 06:33:37 -0800 (PST) +Received: from localhost (dsl-hkibrasgw2-58c371-91.dhcp.inet.fi. + [88.195.113.91]) + by mx.google.com with ESMTPSA id l6sm21191565wjx.33.2015.01.01.06.33.36 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Thu, 01 Jan 2015 06:33:36 -0800 (PST) +From: Jani Nikula +To: Tomi Ollila , David Bremner , + notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] completion: complete notmuch insert --folder + to maildir folders only +In-Reply-To: +References: <1415648143-19923-1-git-send-email-jani@nikula.org> + <1415648143-19923-2-git-send-email-jani@nikula.org> + <871tnfh7yt.fsf@maritornes.cs.unb.ca> + +User-Agent: Notmuch/0.19+3~g7585e8c (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 01 Jan 2015 16:33:45 +0200 +Message-ID: <87zja2woxi.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 01 Jan 2015 14:33:43 -0000 + +On Thu, 01 Jan 2015, Tomi Ollila wrote: +> On Wed, Dec 31 2014, David Bremner wrote: +> +>> Jani Nikula writes: +>>> + local path=`notmuch config get database.path` +>>> + compopt -o nospace +>>> + COMPREPLY=( $(compgen -d "$path/${cur##folder:}" | \ +>>> + sed "s|^$path/||" | grep -v "\(^\|/\)\(cur\|new\|tmp\)$" +>> +>> I'm a bit confused here. Why is 'folder:' being stripped? Too much +>> copy-pasta? +> +> compgen -d wants a directory ? +> +> there seems to be similar strippings done in completion of +> notmuch_search_terms. + + +True, but $cur won't have folder: here. Copy-paste fail. + +Jani. + + +> +>> +>> d +> +> Tomi +> +> PS: if it weren't inconsistent change, just on '#' would suffice ;)