From: David Bremner <david@tethera.net>
Date: Wed, 23 Mar 2016 10:35:12 +0000 (+2100)
Subject: Re: notmuch-reply doesn't use Reply-To
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8b7521e18f850aa5a2058bbbb5ae50a374224c7f;p=notmuch-archives.git

Re: notmuch-reply doesn't use Reply-To
---

diff --git a/0f/8ab0d8a300e2d2ca5a964a222f3f8d461fe627 b/0f/8ab0d8a300e2d2ca5a964a222f3f8d461fe627
new file mode 100644
index 000000000..925abbade
--- /dev/null
+++ b/0f/8ab0d8a300e2d2ca5a964a222f3f8d461fe627
@@ -0,0 +1,78 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 68A1A6DE02AD
+ for <notmuch@notmuchmail.org>; Wed, 23 Mar 2016 03:35:26 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.027
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.027 tagged_above=-999 required=5
+ tests=[AWL=-0.016, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id MaCizaZ_xki7 for <notmuch@notmuchmail.org>;
+ Wed, 23 Mar 2016 03:35:18 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 3EED76DE02A9
+ for <notmuch@notmuchmail.org>; Wed, 23 Mar 2016 03:35:18 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1aig8k-0002qN-7p; Wed, 23 Mar 2016 06:35:50 -0400
+Received: (nullmailer pid 8853 invoked by uid 1000);
+ Wed, 23 Mar 2016 10:35:12 -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, Damien Cassou <damien@cassou.me>,
+ notmuch@notmuchmail.org
+Subject: Re: notmuch-reply doesn't use Reply-To
+In-Reply-To: <87twnygmps.fsf@nikula.org>
+References: <8737vjcx9b.fsf@cassou.me> <8737vi8l7j.fsf@zancas.localnet>
+ <87fuzi9ng5.fsf@cassou.me> <87twnygmps.fsf@nikula.org>
+User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Wed, 23 Mar 2016 07:35:12 -0300
+Message-ID: <8760wdlbxb.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 23 Mar 2016 10:35:26 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+>>
+>> Here is the reply message, and it does not contain the address in Reply-To.
+>
+> This was true way back when notmuch reply only knew about reply all. For
+> --reply-to=sender, it's broken. The simplest "fix" might be
+>
+> diff --git a/notmuch-reply.c b/notmuch-reply.c
+> index 6df54fc992bb..ed0f9cca5c00 100644
+> --- a/notmuch-reply.c
+> +++ b/notmuch-reply.c
+> @@ -334,7 +334,7 @@ add_recipients_from_message (GMimeMessage *reply,
+>       * that the address in the Reply-To header will always appear in
+>       * the reply.
+>       */
+> -    if (reply_to_header_is_redundant (message)) {
+> +    if (reply_to_header_is_redundant (message) && reply_all) {
+>         reply_to_map[0].header = "from";
+>         reply_to_map[0].fallback = NULL;
+>      }
+
+I'm going to mark this fixed for now, since the docs have now been
+updated to match the behaviour.
+
+d