From: Karl Fogel Date: Sat, 5 Jul 2014 18:18:22 +0000 (+1900) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8924dfac0b6e744306f0f985e2769d2e82858b7a;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/70/6b9416422be47e44da66d8f84d17f0e04ea68f b/70/6b9416422be47e44da66d8f84d17f0e04ea68f new file mode 100644 index 000000000..ca2fefea7 --- /dev/null +++ b/70/6b9416422be47e44da66d8f84d17f0e04ea68f @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 012E7431FAF + for ; Sat, 5 Jul 2014 11:18:35 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ZkhlBvtnOVzc for ; + Sat, 5 Jul 2014 11:18:27 -0700 (PDT) +Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com + [209.85.160.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DF1FF431FB6 + for ; Sat, 5 Jul 2014 11:18:26 -0700 (PDT) +Received: by mail-yk0-f180.google.com with SMTP id 131so1084496ykp.39 + for ; Sat, 05 Jul 2014 11:18:26 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to + :message-id:user-agent:mime-version:content-type; + bh=ZaHBGawieH2CY3uvXtQ0xHZCGYY4BRSt4HhwLJeUmFM=; + b=gE2efH3xZEzUQK7NOurHJzEABSPbqLQqh5NDQK0LkBLoN4HnqMJcIGsd8u0EZmC7rL + QY1a0XNR6Jxbw9QFjKGXJlAPILcRSIdJLiDExLNUGbPCOiekpl4bsGAzM9PSsfwMmH3F + H8xmnSifhqNIC+NwishAnZCYAWh974DOtYFFI6PaifURFYoSWnT+xThBEYDxiJFFRD9r + 9S59W4j2uz9Q2TWYEPupO/a6ZMhMb4l/KTdkEGNOp+SnBdBcxCGQ2BNUIk6HD7VyDmIQ + VSZK4miPFrB7b2zwyuf0ETMrH6M4oJnYXNCq9WeMlNJyB/N7ltqNCbbbCHqfwVSNj2Nk + q+tA== +X-Received: by 10.236.25.105 with SMTP id y69mr27170845yhy.33.1404584305188; + Sat, 05 Jul 2014 11:18:25 -0700 (PDT) +Received: from floss.red-bean.com ([2602:30a:2ea0:cc50:8ea9:82ff:febf:1dce]) + by mx.google.com with ESMTPSA id d44sm4648819yhh.13.2014.07.05.11.18.23 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sat, 05 Jul 2014 11:18:24 -0700 (PDT) +Sender: Karl Fogel +From: Karl Fogel +To: Sebastian Lipp +Subject: Re: [PATCH] emacs: add missing paren to fix defun in + notmuch-address.el. +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> <877gkeau42.fsf@floss.red-bean.com> + <8738v1jtzc.fsf@nikula.org> + <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov> + <87vc7vgbym.fsf@zancas.localnet> + + <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + <87oax6vt4u.fsf@ktab.red-bean.com> + <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> +Date: Sat, 05 Jul 2014 13:18:22 -0500 +In-Reply-To: + <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + (Sebastian Lipp's message of "Fri, 04 Jul 2014 11:25:38 +0200") +Message-ID: <87d2djr7o1.fsf@floss.red-bean.com> +User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) +MIME-Version: 1.0 +Content-Type: text/plain +Cc: Tomi Ollila , notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +Reply-To: Karl Fogel +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 Jul 2014 18:18:35 -0000 + +Sebastian Lipp writes: +>No, it happened by intention because what is "original" to you is not +>part of my freshly cloned notmuch. So I thought good practise is to +>construct *one* patch that brings the already fixed feature to the +>notmuch codebase to keep it clean. +> +>If you like better, my next patch will only base Tomis and your +>suggestions on top of the "original" patch. + +Oh, I had thought the changes were already in the notmuch tree. Now I +understand what you're saying, and yes, it makes sense. + +In general, supplying a log message with the patch with avoid such +confusion. If there is some prose expressing what the change is +supposed to to, and giving any historical context (such as the mailing +list thread starting from last year), then it will be easy for any +reviewer to understand what the patch is intended to do, and check if it +actually does that. + +Best, +-Karl