From: W. Trevor King Date: Sat, 8 Feb 2014 17:33:33 +0000 (+1600) Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=88a7d4577c7bf6872f8cdfede6ff7687fd30f0b9;p=notmuch-archives.git Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons --- diff --git a/84/0d31036f0bf2bd32f8e2eec5c4c609c7ad455f b/84/0d31036f0bf2bd32f8e2eec5c4c609c7ad455f new file mode 100644 index 000000000..e29c59899 --- /dev/null +++ b/84/0d31036f0bf2bd32f8e2eec5c4c609c7ad455f @@ -0,0 +1,158 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0F9D4431FBD + for ; Sat, 8 Feb 2014 09:33:44 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.1 +X-Spam-Level: +X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id bRUJfKH+j8bf for ; + Sat, 8 Feb 2014 09:33:36 -0800 (PST) +Received: from qmta09.westchester.pa.mail.comcast.net + (qmta09.westchester.pa.mail.comcast.net [76.96.62.96]) + by olra.theworths.org (Postfix) with ESMTP id 0A739431FBC + for ; Sat, 8 Feb 2014 09:33:35 -0800 (PST) +Received: from omta13.westchester.pa.mail.comcast.net ([76.96.62.52]) + by qmta09.westchester.pa.mail.comcast.net with comcast + id Psdn1n00517dt5G59tZbun; Sat, 08 Feb 2014 17:33:35 +0000 +Received: from odin.tremily.us ([24.18.63.50]) + by omta13.westchester.pa.mail.comcast.net with comcast + id PtZa1n00R152l3L3ZtZb0G; Sat, 08 Feb 2014 17:33:35 +0000 +Received: by odin.tremily.us (Postfix, from userid 1000) + id E646BFFFE14; Sat, 8 Feb 2014 09:33:33 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; + t=1391880813; bh=2kyx42W6DSNKzw5SJdNIodmAJu0RWhfA/5+9H9+JlcQ=; + h=Date:From:To:Cc:Subject:References:In-Reply-To; + b=kCIM9rzu586ukHbxmd5V/ZBnj47gsqEmsHhpa1dS92ldF3gJflhpAlE1U516D0Vdm + mkNzlE3d24YIHKuNQ994vjChleVNA6pHDUsrEFgbvIugxAPSkoqQoXiWv4ZVxLs6tf + AOfDXpDHvsd1vABMUAk1tRhJ53W+zeiSVBY9Fk38= +Date: Sat, 8 Feb 2014 09:33:33 -0800 +From: "W. Trevor King" +To: Mark Walters +Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for + part buttons +Message-ID: <20140208173333.GC17142@odin.tremily.us> +References: <877g9chbay.fsf@qmul.ac.uk> + + <27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us> + <87vbwwosuw.fsf@qmul.ac.uk> <20140203203418.GO14197@odin.tremily.us> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="Izn7cH1Com+I3R9J" +Content-Disposition: inline +In-Reply-To: <20140203203418.GO14197@odin.tremily.us> +OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; + url=http://tremily.us/pubkey.txt +User-Agent: Mutt/1.5.22 (2013-10-16) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20121106; t=1391880815; + bh=TolA2Er9H4hM79rQc52o8KTLN7Af9Vz2I3XVJJO5YTk=; + h=Received:Received:Received:Date:From:To:Subject:Message-ID: + MIME-Version:Content-Type; + b=qSOgpZ/dX9yybafMqVzoOuiG/vT2aC6LIjDoIuuI2H2GvVMJLi+MyV4MlvWwlm7GB + 0u76sXsM+AqZJM9n59vilyWLN6fg2/B3IJTuHi0m+z8AAyu6xjsMxfAMrS4QLtaADt + UOp15zr7kj5q2jDTuNuudK3MyEj9zZqOQjzl0venxhCOe4rBw2LhS9yRsiGBMSzxYY + xMJMn6LN5WR57YRzH1s5rZMCDv09vTtGH2WplyzKemyCqVnqTM0qPiae1O4uHnEXOR + 0Q3Gq3PC6ys9TuPYWfyVI4270Cxs4wS5YUk+Mj20lir2qD6Iry2rEts+jPSEIAaaKI + SgQv9UN5vVh3Q== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 08 Feb 2014 17:33:44 -0000 + + +--Izn7cH1Com+I3R9J +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Mon, Feb 03, 2014 at 12:34:18PM -0800, W. Trevor King wrote: +> On Mon, Feb 03, 2014 at 08:15:35PM +0000, Mark Walters wrote: +> > My only other comment on the series is that you should update +> > devel/schemata in the first patch to reflect this addition. +>=20 +> Ah, I didn't realize that file existed :p. + +Looking at this more, I'm unsure about whether or not I should bump +the version. b96ba63 (show: indicate length, encoding of omitted body +content, 2012-12-16) added part.content-length? and +part.content-transfer-encoding? and doesn't bump the version, while +abeac48 (search: Add stable queries to thread search results, +2013-10-24) adds thread_summary.query and does bump the version. From +notmuch-client.h: + + Backwards-incompatible changes such as removing map fields, changing + the meaning of map fields, or changing the meanings of list elements + should increase this. New (required) map fields can be added without + increasing this. + +I think that the addition of part.content-description? should not bump +the version, but then I'm not sure how to document the change in +devel/schemata. I'm leaning towards something like: + + diff --git a/devel/schemata b/devel/schemata + index 41dc4a6..63d8aa4 100644 + --- a/devel/schemata + +++ b/devel/schemata + @@ -26,6 +26,9 @@ v1 + v2 + - Added the thread_summary.query field. + + +Staged for v3 + +- Added the part.content-descrition? field. + + + Common non-terminals + -------------------- + =E2=80=A6 + +Alternatively, there could be a minor version that gets bumped on each +tweak, however insignificant. + +Thoughts? + +Trevor + +--=20 +This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy + +--Izn7cH1Com+I3R9J +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.22 (GNU/Linux) + +iQIcBAEBAgAGBQJS9mprAAoJEKKfehoaNkbtr7UP/iNtM8JLTfjxmldBtMXiaaIr +pDQCggBf0fv4e/JtIpqbDqENapog/vZCDm8QxBLCxjMOVIVauanUqqw8g9U5DUvX +5y4glW9iG1fpBFFmfjy/2etxbs9W5SyEVbpMlXPbtQxPdWjtheJSoPfktbknuBT2 +iUXWkZHsWL4o1hn+MtJ09EhcUWOFr/o2YtH7oLznsuZshsDFHOqWLHnB7vbNI8P2 +zFP0iDBDCnVuRLKuC/7aWk82lzVMoD2FI9Hr4Mp3ryIR9/ByR+4+1CjpNGzJ/Lxa +nN83cQrAFG024Y7OklRX+G/mDeUjIHBXrSj2Rw9QtQFhJPc8cPNMSBqZn1nIfbKK +s3czIqwhRdU9fbVmG+TtjLAiT6Km+dkQztpV/sdscRqzU+zjkwIwF6Y8giS4t1mQ +3Srt9vHMg9AoaLPrydbg9R9pN5ROsO3NwINcxpyz7wGQebbtWbpKrIeHTZMoF62K +sdIZONARnVHD00JaFNuLb8VmtaifnSsq2gUhtJeADNIiarNKrcWfUa0WxOxU2u2Z +gYczozP4sZBIsvQdNyCmCyrbaIw9XD59RFbksFqaoQKOxe+qDphr4H29xzPuklMO +UdiDvFD9Vp9iQ1Db0TjmLOVrJFGLOJm+D/fwIfCCgWSDDEAQeZIhspZXgP2Xrz5u +497VrnvdUXMVWrn6d0qn +=zORU +-----END PGP SIGNATURE----- + +--Izn7cH1Com+I3R9J--