From: David Bremner <david@tethera.net>
Date: Fri, 12 Aug 2016 08:04:20 +0000 (+0900)
Subject: Re: [PATCH v4 04/16] Provide _notmuch_crypto_{set,get}_gpg_path
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=888ee1f1f4f73c1f649bf54173a04b9b57cf8cc7;p=notmuch-archives.git

Re: [PATCH v4 04/16] Provide _notmuch_crypto_{set,get}_gpg_path
---

diff --git a/1c/be8b6271730bb5ee0af449919d2547e9e6398f b/1c/be8b6271730bb5ee0af449919d2547e9e6398f
new file mode 100644
index 000000000..3133e6aaf
--- /dev/null
+++ b/1c/be8b6271730bb5ee0af449919d2547e9e6398f
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 030AC6DE092F
+ for <notmuch@notmuchmail.org>; Fri, 12 Aug 2016 01:04:33 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.008
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.008 tagged_above=-999 required=5 tests=[AWL=0.003,
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id hEoEe7Aqx_G0 for <notmuch@notmuchmail.org>;
+ Fri, 12 Aug 2016 01:04:25 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 3459F6DE092E
+ for <notmuch@notmuchmail.org>; Fri, 12 Aug 2016 01:04:25 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
+ (envelope-from <david@tethera.net>)
+ id 1bY7SH-0008BJ-Jc; Fri, 12 Aug 2016 04:04:37 -0400
+Received: (nullmailer pid 9546 invoked by uid 1000);
+ Fri, 12 Aug 2016 08:04:20 -0000
+From: David Bremner <david@tethera.net>
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v4 04/16] Provide _notmuch_crypto_{set,get}_gpg_path
+In-Reply-To: <1467970047-8013-5-git-send-email-dkg@fifthhorseman.net>
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>
+ <1467970047-8013-5-git-send-email-dkg@fifthhorseman.net>
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Fri, 12 Aug 2016 17:04:20 +0900
+Message-ID: <87tweqpg57.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 12 Aug 2016 08:04:33 -0000
+
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
+
+
+> +notmuch_status_t
+> +_notmuch_crypto_set_gpg_path (_notmuch_crypto_t *crypto, const char *gpg_path)
+> +{
+[snip]
+> +    if (! gpg_path && ! test_for_executable (gpg_path))
+> +	return NOTMUCH_STATUS_FILE_ERROR;
+
+this looks strange. Maybe the "!" in front of gpg_path might be
+spurious. Or maybe you mean || ?
+
+> -    const char *gpgpath;
+> +    char *gpg_path;
+>  } _notmuch_crypto_t;
+
+Why is const dropped here?
+>