From: David Bremner <david@tethera.net>
Date: Tue, 24 May 2016 11:48:11 +0000 (+2100)
Subject: Re: [Patch v5 05/11] lib: provide config API
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=881e8543c3b105b80876ed675e45add1977322d5;p=notmuch-archives.git

Re: [Patch v5 05/11] lib: provide config API
---

diff --git a/5e/2591d6468f10a03beed0fab85f346e56ab9d05 b/5e/2591d6468f10a03beed0fab85f346e56ab9d05
new file mode 100644
index 000000000..1e02dce77
--- /dev/null
+++ b/5e/2591d6468f10a03beed0fab85f346e56ab9d05
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id C86EF6DE01F7
+ for <notmuch@notmuchmail.org>; Tue, 24 May 2016 04:48:23 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.012
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.012 tagged_above=-999 required=5
+ tests=[AWL=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 6hDp1n13h77o for <notmuch@notmuchmail.org>;
+ Tue, 24 May 2016 04:48:16 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id ED5CB6DE00C6
+ for <notmuch@notmuchmail.org>; Tue, 24 May 2016 04:48:15 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1b5Aoe-0004EV-IF; Tue, 24 May 2016 07:48:04 -0400
+Received: (nullmailer pid 21715 invoked by uid 1000);
+ Tue, 24 May 2016 11:48:11 -0000
+From: David Bremner <david@tethera.net>
+To: notmuch@notmuchmail.org
+Subject: Re: [Patch v5 05/11] lib: provide config API
+In-Reply-To: <1463135893-7471-6-git-send-email-david@tethera.net>
+References: <1463135893-7471-1-git-send-email-david@tethera.net>
+ <1463135893-7471-6-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.22+15~g1aa6f90 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Tue, 24 May 2016 08:48:11 -0300
+Message-ID: <87iny3n0ck.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 24 May 2016 11:48:23 -0000
+
+David Bremner <david@tethera.net> writes:
+> +	notmuch->exception_reported = TRUE;
+> +	if (! notmuch->exception_reported) {
+> +	    _notmuch_database_log (notmuch, "Error: A Xapian exception occurred setting metadata: %s\n",
+> +				   error.get_msg().c_str());
+> +	}
+
+Upon revisiting, this looks pretty silly. According to the commit
+message in e2341cb the point of exception_reported is to avoid excess
+error reporting when closing/flushing after another error. Since we
+don't actually print these error messages anymore, I'm not sure it's
+even needed.  In any case, this is a bad case of copy-pasta, which I've
+fixed in git by removing the if (in both places).
+