From: Austin Clements Date: Mon, 10 Jun 2013 05:07:34 +0000 (+2000) Subject: Re: [PATCH v5 0/6] emacs: show: lazy handling of hidden parts X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=870ce37786cd2937b8ed25614c45cd0f4df910bb;p=notmuch-archives.git Re: [PATCH v5 0/6] emacs: show: lazy handling of hidden parts --- diff --git a/bf/984b0a3ad67f310cca59415976071c08fb72be b/bf/984b0a3ad67f310cca59415976071c08fb72be new file mode 100644 index 000000000..86ec812dd --- /dev/null +++ b/bf/984b0a3ad67f310cca59415976071c08fb72be @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 17BED431FAF + for ; Sun, 9 Jun 2013 22:07:47 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id LAWk8kqHe7hX for ; + Sun, 9 Jun 2013 22:07:39 -0700 (PDT) +Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu + [18.9.25.14]) + by olra.theworths.org (Postfix) with ESMTP id 8890B431FAE + for ; Sun, 9 Jun 2013 22:07:39 -0700 (PDT) +X-AuditID: 1209190e-b7fa46d000006e53-1b-51b55f1b886b +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP + id F8.49.28243.B1F55B15; Mon, 10 Jun 2013 01:07:39 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r5A57baJ027350; + Mon, 10 Jun 2013 01:07:38 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5A57Z91030903 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Mon, 10 Jun 2013 01:07:36 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1UluKN-0006tt-5O; Mon, 10 Jun 2013 01:07:35 -0400 +Date: Mon, 10 Jun 2013 01:07:34 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH v5 0/6] emacs: show: lazy handling of hidden parts +Message-ID: <20130610050734.GD22196@mit.edu> +References: <1370840233-23258-1-git-send-email-markwalters1009@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1370840233-23258-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1pWO3xpoMG0hl8XquTwW12/OZHZg + 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mo4v3cle0M9esW3fd7YGxgusXYycHBICJhJ9 + C5rYIWwxiQv31rN1MXJxCAnsY5ToefKWHcLZyCix8dJHqMxpJolZ3z8wQzhLGCUa1j9kA+ln + EVCVeLj2PAuIzSagIbFt/3JGEFtEQEfi9qEFYDuYBaQlvv1uZgKxhQXcJL68egRWwwtUc2np + BLA5QgKeEj//7mKHiAtKnJz5hAWiV0vixr+XQL0cYHOW/+MACXMKeEnsWN4LViIqoCIx5eQ2 + tgmMQrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXWO93MwSvdSU0k2M4LCW + 5NvB+PWg0iFGAQ5GJR7eB7+2BAqxJpYVV+YeYpTkYFIS5d0ZtTVQiC8pP6UyI7E4I76oNCe1 + +BCjBAezkgjvT0ugHG9KYmVValE+TEqag0VJnPdKyk1/IYH0xJLU7NTUgtQimKwMB4eSBG94 + HFCjYFFqempFWmZOCUKaiYMTZDgP0HAjkBre4oLE3OLMdIj8KUZFKXFePZCEAEgiozQPrheW + dl4xigO9IsxrDlLFA0xZcN2vgAYzAQ2eor4FZHBJIkJKqoExSfV58LUFS2b8fr5dtdpi/moJ + AUOZxXqbV24+c3X7LSumh1MNuarFFS5v3XSx3tTr1T19PcWoxcZ31geGfc09nf63Zm7UkQU3 + pUWmLZiUfOz1rM0nvs7ZYf4p2mga5+NFdTxcJrnuCt/Md59+wP/5h+VE3gD9+wEbuq/FH3I2 + OdD6orjSTG2isBJLcUaioRZzUXEiAM72ZkkWAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 10 Jun 2013 05:07:47 -0000 + +LGTM. + +Quoth Mark Walters on Jun 10 at 5:57 am: +> This is version 5 of this patch set. Version 4 is at +> id:1370074547-24677-1-git-send-email-markwalters1009@gmail.com. +> +> This version fixes the two bugs pointed out in Austin's review +> id:20130610023952.GC22196@mit.edu. +> +> I decided to add the :notmuch-part text property separately from +> create-overlays as they have slightly different regions (one includes +> the button one does not) and are applied at slightly different times +> (we do not create overlays for lazy parts). +> +> I was not sure whether we created two overlays for hidden lazy parts +> in v4 (it might not have done as the part was empty and we do not +> create overlays for empty parts) but that is stupidly fragile. Thus we +> explicitly do not create overlays for lazy parts until they are +> inserted. +> +> The diff from v4 is below. +> +> Best wishes +> +> Mark