From: Jerald Fitzjerald <jfj@freemail.gr>
Date: Wed, 30 May 2007 12:39:58 +0000 (-0700)
Subject: decode_85(): fix missing return.
X-Git-Tag: v1.5.2.1~4^2~2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=86d14e1b1d1063fc943c71edc8b05e1ce32c1602;p=git.git

decode_85(): fix missing return.

When the function detected an invalid base85 sequence, it issued
an error message but forgot to return error status at that point
and kept going.

Signed-off-by: Jerald Fitzjerald <jfj@freemail.gr>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/base85.c b/base85.c
index a6c41d597..b88270f90 100644
--- a/base85.c
+++ b/base85.c
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buffer, int len)
 		 */
 		if (0x03030303 < acc ||
 		    0xffffffff - de < (acc *= 85))
-			error("invalid base85 sequence %.5s", buffer-5);
+			return error("invalid base85 sequence %.5s", buffer-5);
 		acc += de;
 		say1(" %08x", acc);