From: David Bremner Date: Sat, 7 May 2016 22:27:52 +0000 (+2100) Subject: Re: [PATCH] configure: add set -u X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=84932bb36d9ef83aab9820f2223a2263e03eb165;p=notmuch-archives.git Re: [PATCH] configure: add set -u --- diff --git a/23/b62131fb7667de7878e184e5ddfecc4fe82f07 b/23/b62131fb7667de7878e184e5ddfecc4fe82f07 new file mode 100644 index 000000000..67326f24a --- /dev/null +++ b/23/b62131fb7667de7878e184e5ddfecc4fe82f07 @@ -0,0 +1,62 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id BAC456DE0217 + for ; Sat, 7 May 2016 15:28:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.013 +X-Spam-Level: +X-Spam-Status: No, score=-0.013 tagged_above=-999 required=5 + tests=[AWL=-0.002, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RYyyt3GcVXpT for ; + Sat, 7 May 2016 15:27:56 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 0F7FA6DE00EB + for ; Sat, 7 May 2016 15:27:55 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1azAhQ-0008Ik-Ex; Sat, 07 May 2016 18:27:48 -0400 +Received: (nullmailer pid 27343 invoked by uid 1000); + Sat, 07 May 2016 22:27:52 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Cc: tomi.ollila@iki.fi +Subject: Re: [PATCH] configure: add set -u +In-Reply-To: <1462558285-10936-1-git-send-email-tomi.ollila@iki.fi> +References: <1462296224-768-1-git-send-email-tomi.ollila@iki.fi> + <1462558285-10936-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 07 May 2016 19:27:52 -0300 +Message-ID: <874ma94i6v.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 07 May 2016 22:28:04 -0000 + +Tomi Ollila writes: + +> In case of any unset variable, make ./configure exit with nonzero value; +> an attempt to expand an unset variable is a bug in the script +> (usually a spelling mistake) and those should not pass through +> unnoticed. + +pushed these two to master + +d