From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Fri, 3 Oct 2014 20:49:31 +0000 (+0300)
Subject: Re: [PATCH 1/2] test: check for debug symbols in notmuch
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8419588f45ff7eb83864accbcf014cdbedc8290f;p=notmuch-archives.git

Re: [PATCH 1/2] test: check for debug symbols in notmuch
---

diff --git a/b4/14c6eed244c80cd0b80f52e70ac573dc70c04d b/b4/14c6eed244c80cd0b80f52e70ac573dc70c04d
new file mode 100644
index 000000000..9015b3891
--- /dev/null
+++ b/b4/14c6eed244c80cd0b80f52e70ac573dc70c04d
@@ -0,0 +1,86 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 21EE4431FBC
+	for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 13:49:47 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Mz0DUoEg7la7 for <notmuch@notmuchmail.org>;
+	Fri,  3 Oct 2014 13:49:43 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id D4834431FB6
+	for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 13:49:42 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id AD54A10008D;
+	Fri,  3 Oct 2014 23:49:31 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/2] test: check for debug symbols in notmuch
+In-Reply-To: <1412367730-25890-1-git-send-email-david@tethera.net>
+References: <1412367730-25890-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.18.1+119~g5d90feb (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Fri, 03 Oct 2014 23:49:31 +0300
+Message-ID: <m21tqoho9w.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 03 Oct 2014 20:49:47 -0000
+
+On Fri, Oct 03 2014, David Bremner <david@tethera.net> wrote:
+
+> In the future, tests may rely on debug symbols being present in
+> notmuch, so we plan to switch the default flags.
+>
+> The main purpose of this test is to help explain the perhaps
+> mysterious failures of other tests which rely on symbols being
+> present.
+> ---
+
+series LGTM.
+
+>  test/T000-basic.sh | 5 +++++
+>  1 file changed, 5 insertions(+)
+>
+> diff --git a/test/T000-basic.sh b/test/T000-basic.sh
+> index ebbb6d2..bf08f3e 100755
+> --- a/test/T000-basic.sh
+> +++ b/test/T000-basic.sh
+> @@ -91,4 +91,9 @@ test_expect_equal \
+>      "$(dirname ${TEST_DIRECTORY})" \
+>      "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')"
+>  
+> +test_begin_subtest 'notmuch is compiled with debugging symbols'
+> +test_subtest_known_broken
+> +readelf --sections $(which notmuch) | grep \.debug
+> +test_expect_equal 0 $?
+> +
+>  test_done
+> -- 
+> 2.1.0
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch