From: Brandon Casey <drafnel@gmail.com>
Date: Mon, 21 Jun 2010 17:37:13 +0000 (-0500)
Subject: t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression
X-Git-Tag: v1.7.2-rc1~7^2~3
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=832ac79edf0e0e9108f5da5b10b496a227667f40;p=git.git

t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression

Regular expressions matched by 'expr' have an implicit '^' at the beginning
of them and so are anchored to the beginning of the string.  Using the '^'
character to mean "match at the beginning", is redundant and could produce
the wrong result if 'expr' implementations interpret the '^' as a literal
'^'.  Additionally, GNU expr 5.97 complains like this:

   expr: warning: unportable BRE: `^[a-z][a-z]*$': using `^' as the first character of the basic regular expression is not portable; it is being ignored

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/lib-pager.sh b/t/lib-pager.sh
index f8c602587..ba03eab14 100644
--- a/t/lib-pager.sh
+++ b/t/lib-pager.sh
@@ -9,7 +9,7 @@ test_expect_success 'determine default pager' '
 	test -n "$less"
 '
 
-if expr "$less" : '^[a-z][a-z]*$' >/dev/null
+if expr "$less" : '[a-z][a-z]*$' >/dev/null
 then
 	test_set_prereq SIMPLEPAGER
 fi