From: David Bremner <david@tethera.net>
Date: Sat, 12 Mar 2016 16:33:50 +0000 (+2000)
Subject: Re: [PATCH] use notmuch_database_open_verbose
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8279d899760ffb02581592d68626651d507d5ae5;p=notmuch-archives.git

Re: [PATCH] use notmuch_database_open_verbose
---

diff --git a/1e/4e9bd785a212c86105360bbee8734d0d443afe b/1e/4e9bd785a212c86105360bbee8734d0d443afe
new file mode 100644
index 000000000..a20ef0e6d
--- /dev/null
+++ b/1e/4e9bd785a212c86105360bbee8734d0d443afe
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id CD2826DE1868
+ for <notmuch@notmuchmail.org>; Sat, 12 Mar 2016 08:33:54 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.031
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.031 tagged_above=-999 required=5
+ tests=[AWL=-0.020, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id GKsqVBwQ8VhZ for <notmuch@notmuchmail.org>;
+ Sat, 12 Mar 2016 08:33:53 -0800 (PST)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id D664E6DE1867
+ for <notmuch@notmuchmail.org>; Sat, 12 Mar 2016 08:33:52 -0800 (PST)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1aemUn-0007wX-AX; Sat, 12 Mar 2016 11:34:29 -0500
+Received: (nullmailer pid 32316 invoked by uid 1000);
+ Sat, 12 Mar 2016 16:33:50 -0000
+From: David Bremner <david@tethera.net>
+To: Patrick Totzke <patricktotzke@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] use notmuch_database_open_verbose
+In-Reply-To: <87r3ff64sa.fsf@zancas.localnet>
+References: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com>
+ <87r3ff64sa.fsf@zancas.localnet>
+User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sat, 12 Mar 2016 12:33:50 -0400
+Message-ID: <87oaaj64gh.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 12 Mar 2016 16:33:55 -0000
+
+David Bremner <david@tethera.net> writes:
+
+>> -    """notmuch_database_open"""
+>> -    _open = nmlib.notmuch_database_open
+>> +    """notmuch_database_open_verbose"""
+>> +    _open = nmlib.notmuch_database_open_verbose
+>>      _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)]
+>>      _open.restype = c_uint
+>
+> I expect you probably want to add the new binding, rather than replacing
+> the old one. Otherwise updating the bindings will break all bindings
+> using scripts.
+
+Oh silly me. That's not actually exposed to the python API, so that's
+fine. On the other hand, don't you want to update the argument types and
+do something useful (throw an exception?) with the returned message?  As
+it stands you lose information.
+
+d