From: Zac Medico Date: Fri, 21 Nov 2008 21:28:58 +0000 (-0000) Subject: In EbuildProcess._start(), don't open the log file during the clean phase X-Git-Tag: v2.1.6_rc1~28 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=826a95ce77c9ea2dccf74d7317c212be42d29cea;p=portage.git In EbuildProcess._start(), don't open the log file during the clean phase since the open file can result in an nfs lock on $T/build.log which prevents the clean phase from removing $T. Thanks to Jeremy Olexa for reporting. (trunk r12016) svn path=/main/branches/2.1.6/; revision=12017 --- diff --git a/pym/_emerge/__init__.py b/pym/_emerge/__init__.py index 689dffa2f..f261ebaf7 100644 --- a/pym/_emerge/__init__.py +++ b/pym/_emerge/__init__.py @@ -2866,7 +2866,11 @@ class EbuildProcess(SpawnProcess): __slots__ = ("phase", "pkg", "settings", "tree") def _start(self): - self.logfile = self.settings.get("PORTAGE_LOG_FILE") + # Don't open the log file during the clean phase since the + # open file can result in an nfs lock on $T/build.log which + # prevents the clean phase from removing $T. + if self.phase not in ("clean", "cleanrm"): + self.logfile = self.settings.get("PORTAGE_LOG_FILE") SpawnProcess._start(self) def _pipe(self, fd_pipes):