From: W. Trevor King Date: Fri, 12 Feb 2016 19:38:40 +0000 (+1600) Subject: Re: [PATCH] test/README: have matching test script file names X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=8167c619f4047cd1e5fd7ac798194ae1b259c01a;p=notmuch-archives.git Re: [PATCH] test/README: have matching test script file names --- diff --git a/ba/84715cbac1b5779c88ba18f30906cc04f0f0f6 b/ba/84715cbac1b5779c88ba18f30906cc04f0f0f6 new file mode 100644 index 000000000..fbca37268 --- /dev/null +++ b/ba/84715cbac1b5779c88ba18f30906cc04f0f0f6 @@ -0,0 +1,140 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id D0A4E6DE17DB + for ; Fri, 12 Feb 2016 11:38:47 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.008 +X-Spam-Level: +X-Spam-Status: No, score=0.008 tagged_above=-999 required=5 tests=[AWL=0.109, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fTC-eeCWonDz for ; + Fri, 12 Feb 2016 11:38:44 -0800 (PST) +Received: from resqmta-po-04v.sys.comcast.net (resqmta-po-04v.sys.comcast.net + [96.114.154.163]) + by arlo.cworth.org (Postfix) with ESMTPS id 48CD06DE1638 + for ; Fri, 12 Feb 2016 11:38:44 -0800 (PST) +Received: from resomta-po-05v.sys.comcast.net ([96.114.154.229]) + by resqmta-po-04v.sys.comcast.net with comcast + id HXcu1s0094xDoy801XejfR; Fri, 12 Feb 2016 19:38:43 +0000 +Received: from mail.tremily.us ([73.221.72.168]) + by resomta-po-05v.sys.comcast.net with comcast + id HXeh1s0093dr3C901XehcP; Fri, 12 Feb 2016 19:38:42 +0000 +Received: by mail.tremily.us (Postfix, from userid 1000) + id DC40C1BAF067; Fri, 12 Feb 2016 11:38:40 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; + t=1455305920; bh=wLY4uRTVuFPUuZBIoedhVKtrnAcUQK1RALfQG4itJKU=; + h=Date:From:To:Cc:Subject:References:In-Reply-To; + b=jw5hGc8fL5DnGAew4wBaAqRFf5G9y48VS2wy6U1HOhhbj3aIxdYJTRFeR5mt6zdoO + c7leGc+LkYZynmbJqvf+Qqr0cTku5/l4sIZTOtZmUlDTvak4lsaJmksW3eS20mFOm4 + XzUQYVuexyY3bk6VdhzuUvI9kwwMdF/rlmdlzpOM= +Date: Fri, 12 Feb 2016 11:38:40 -0800 +From: "W. Trevor King" +To: Tomi Ollila +Cc: notmuch@notmuchmail.org +Subject: Re: [PATCH] test/README: have matching test script file names +Message-ID: <20160212193840.GV4265@odin.tremily.us> +References: <1455304620-14588-1-git-send-email-tomi.ollila@iki.fi> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="gkEBo/XPSfx+3zOU" +Content-Disposition: inline +In-Reply-To: <1455304620-14588-1-git-send-email-tomi.ollila@iki.fi> +OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; + url=http://tremily.us/pubkey.txt +User-Agent: Mutt/1.5.23 (2014-03-12) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20140121; t=1455305923; + bh=WbgPflleR0zhKCZklb83VO2o9WGiD6K+Aac0hga8sI4=; + h=Received:Received:Received:Date:From:To:Subject:Message-ID: + MIME-Version:Content-Type; + b=W9+p7EoJ3n0U7Z+yE4gPhMGOBVjT9UmeShgVE542MCdu0HdO4i+ZuZ91z4hXVOfpr + ny1HHk9B/wDek7BPS40WQN+JmO9faBO5pRnTH8kjy+2iD76t1l+9Iu/nDR26qzF7+9 + 01HRLK0dzllKd6a6JQdtIT8GCHfSCEBiJWla5e/K6T4F82v+MkZN4EDSqslRRxBNT7 + 1viAIefWD0ai8ftkSCdidKDK2YnEgDqwTv5rMnb2fwypPYY+4crxQZJoFxyVG21eUc + UH66s7DInuZTj9F8vtch14t1FtUXNsmZQglgQiXZinh+zcKoJyr8GKcOJe0pu1s/cv + UEuk0aEjDWylw== +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 12 Feb 2016 19:38:48 -0000 + + +--gkEBo/XPSfx+3zOU +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Fri, Feb 12, 2016 at 09:17:00PM +0200, Tomi Ollila wrote: +> +The test system itself requires: +> + +> + - bash(1) version 4.0 or newer +> + +> +Without bash 4.0+ the tests just refuse to run. + +This was surprising to me (obviously I haven't looked at the test +library closely ;), because Git tries to maintain compatiblity with +POSIX [1] and Git is the source of notmuch's test framework [2]. But +it looks like notmuch's fork of the test framework was Bash-specific +=66rom 0d67c52f (notmuch-test: Use named-parameters for generate_message +function, 2010-02-03). That commit happened before the Git framework, +but we still have the code it added: + + # This is our (bash-specific) magic for doing named parameters = + = + =20 + local -A template=3D"($@)" + +Carl explicitly motivated the change in his commit message. +1 to +documenting the requirement explicitly in the README, although users +should have been getting nice error messages since 20018a0c (test: +Emit a friendly error message if run with bash < 4.0, 2010-10-28). + +Cheers, +Trevor + +[1]: https://git.kernel.org/cgit/git/git.git/tree/Documentation/CodingGuide= +lines?h=3Dv2.7.1 +[2]: 0083854 (Copy test framework from Git, 2010-06-10) + +--=20 +This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy + +--gkEBo/XPSfx+3zOU +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2 + +iQIcBAEBAgAGBQJWvjS+AAoJEAPqygegUbGsBsAQAIcqG/DhfnqMIXtZRzbyAfw8 +XswP2r2p3DWB7r9UMiBV2PNbY6epeLl0fMX/1baRdrb5QZlfLrews4A0ctOvGMle +WOcxL2GFx37b2yzJ3iQcEbZ49E7Ns/0hmKPS6eD6NXVksMr0ujGNPowbUBC8qJ0c +lCPmwcQIDCCZxAB9smhszTYuTjgi84cwS3VfxbrOD0WBbiKD+tCZ/2ghIf2rYpSQ +Ziwm6JLPwalifO3uisjT01YtkbPHd9YMdSIrPH5giMcEUuXA2Mk2D0BYpPmiiX+g +VZjUEcYES4ko1IyhMlzQcxFoEqIkl6SvZYm2Tn/apHmaCzEZyB9qNTH/+HbhkQwI +XnHqcW4SqmsZN+4meB19FdNdNY/Qe/pLyZLKxpz6enXLt+paahc/Lxv86E86MPCO +Q2OFw6IaobYUCGjPyy1g4OfBj/PCSS0fRc+4fyTGlMip449uIRDGLB4z/0sjYGDn +XIlBUlW6HFpyS5hMjSX3OP0IelEl7hBJUYLJE2AbdpLp1Rfb52e8VJioMPpWFykZ +0Yp1DTb0WiVwwX17mjrUixYKFLBXuQiNejd4j+e39/lFEhQgt/Qc+/Wc45KV348y +m+6IJqc5c45zpdlxWRWQg+Ilplu6fTGjwmPrP/Orahl3adunxsHCL9nxhOwbsOfK +6szdocDPbHY9wZ5HHIct +=ZPVl +-----END PGP SIGNATURE----- + +--gkEBo/XPSfx+3zOU--