From: Daniel Schoepe Date: Sat, 15 Aug 2015 07:21:49 +0000 (+0200) Subject: Re: [PATCH 3/5] cli/count: add --lastmod X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=80faa55d99ee094a92fe4ae6104bdcc629b88c6f;p=notmuch-archives.git Re: [PATCH 3/5] cli/count: add --lastmod --- diff --git a/32/c8974b4426802d00e0337950c9514dfd2d33ab b/32/c8974b4426802d00e0337950c9514dfd2d33ab new file mode 100644 index 000000000..944103872 --- /dev/null +++ b/32/c8974b4426802d00e0337950c9514dfd2d33ab @@ -0,0 +1,96 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 70B306DE1552 + for ; Sat, 15 Aug 2015 00:21:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.11 +X-Spam-Level: +X-Spam-Status: No, score=-0.11 tagged_above=-999 required=5 tests=[AWL=0.097, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_WEB=0.614, SPF_PASS=-0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ZgXTABtnE82t for ; + Sat, 15 Aug 2015 00:21:57 -0700 (PDT) +Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com + [209.85.212.169]) + by arlo.cworth.org (Postfix) with ESMTPS id B7AC56DE1422 + for ; Sat, 15 Aug 2015 00:21:56 -0700 (PDT) +Received: by wicne3 with SMTP id ne3so34836435wic.0 + for ; Sat, 15 Aug 2015 00:21:55 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=DWGn9Ot5xGa2TEnU9xFa5K3aXywETUDxrzI1f+/+K4g=; + b=RHv0u7w4rqDDnR5SdsmlImkDTVvVH8G2gpwDfbXxed5G0JXZNsHQhSN7lylLDZ49EN + dwy4pVNPx//JOBD0ZOJtZRaOvlY4gQqGAf0Qp5ozZ9eVLLPeXOHzyGENh/jSnxCJYY5/ + /ZT9yt8yz0tX7umqgS7sBjxtodXE4T3Zu2Ucc= +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=DWGn9Ot5xGa2TEnU9xFa5K3aXywETUDxrzI1f+/+K4g=; + b=S7aZO3aBHZugQGZHGQR45tbj7vKZwCorXODsC9m9rOlMmVvNJBL7KvdqqcWK2FTPf/ + FdaMUp76VHHPgxluhHewF9GagSMrIkShvVKkoLqfe0rk3k0em4MIeFrKv50Jw9XDBAOV + Nz/jkoIPoiI0ETu5J6VaE5BMvx0yG1FexsKjNTGEylatF02pTgUIwuXjAe9Dp2WOPCfw + KSeFLz1XRdqp2YUYHANEHe7C1UCO/d2bZBJ53e2AExD2Z2NjmLT+IMaioxbPLOHs2FCL + 12ESUcEs/phxBwg39rVIXqRip+gaoKOwQenGY3v5kZEdTXs0ymOu3s2u6y3h+qzODK2F + gl4Q== +X-Gm-Message-State: + ALoCoQmc/VllZwoqYjdLe/jGj70GEqIot5UFnjzIpzJj1PJJdVJdCSrzvh0cqs1C2fVMVfogiWJO +X-Received: by 10.194.58.130 with SMTP id r2mr7785256wjq.72.1439623314826; + Sat, 15 Aug 2015 00:21:54 -0700 (PDT) +Received: from localhost (ip-80-226-24-12.vodafone-net.de. [80.226.24.12]) + by smtp.gmail.com with ESMTPSA id bg9sm3005727wib.16.2015.08.15.00.21.52 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 15 Aug 2015 00:21:53 -0700 (PDT) +From: Daniel Schoepe +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 3/5] cli/count: add --lastmod +In-Reply-To: <1439570878-15165-4-git-send-email-david@tethera.net> +References: <1439570878-15165-1-git-send-email-david@tethera.net> + <1439570878-15165-4-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.20.2+64~g9f61b4c (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-unknown-linux-gnu) +Date: Sat, 15 Aug 2015 09:21:49 +0200 +Message-ID: <878u9dyq2a.fsf@schoepe.localhost> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 15 Aug 2015 07:21:59 -0000 + +On Fri, 14 Aug 2015 18:47 +0200, David Bremner wrote: +> + ``--lastmod`` +> + Append lastmod (counter for number of database updates) and UUID +> + to the output. lastmod values are only comparable between databases +> + with the same UUID. + +Sorry to keep harping on this, but I'm not entirely happy with the way +we handle notmuch-compact here (and in the other commit that mentions +compacting explicitly). Given that lastmod values (and pretty much +everything else) aren't affected by compacting, would it perhaps make +sense to copy the previous UUID to the newly compacted database? + +Given that a compacted database is "indistinguishable" from the previous +non-compacted database, we may want to signal that it's still the "same +database". Is there a case where compacting actually makes a difference +to anything making use of lastmod values? + +Best regards, +Daniel