From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 8 Dec 2015 13:15:09 +0000 (+0200)
Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=80b09803ea2866b39ef13eef04fdc45d4d4fb30a;p=notmuch-archives.git

Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro
---

diff --git a/c9/bf02137b83ffa3b537dd8002a3c70663cf81ed b/c9/bf02137b83ffa3b537dd8002a3c70663cf81ed
new file mode 100644
index 000000000..969a876f1
--- /dev/null
+++ b/c9/bf02137b83ffa3b537dd8002a3c70663cf81ed
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 1BAC86DE17ED
+ for <notmuch@notmuchmail.org>; Tue,  8 Dec 2015 05:15:06 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.706
+X-Spam-Level: 
+X-Spam-Status: No, score=0.706 tagged_above=-999 required=5 tests=[AWL=0.054, 
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id e0RlS3NTyqh5 for <notmuch@notmuchmail.org>;
+ Tue,  8 Dec 2015 05:15:03 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 70A5F6DE17CB
+ for <notmuch@notmuchmail.org>; Tue,  8 Dec 2015 05:15:03 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 1FEEB10004A;
+ Tue,  8 Dec 2015 15:15:09 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro
+In-Reply-To: <87egexyusl.fsf@zancas.localnet>
+References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi>
+ <87egexyusl.fsf@zancas.localnet>
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Tue, 08 Dec 2015 15:15:09 +0200
+Message-ID: <m27fkpozdu.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 08 Dec 2015 13:15:06 -0000
+
+On Tue, Dec 08 2015, David Bremner <david@tethera.net> wrote:
+
+> Tomi Ollila <tomi.ollila@iki.fi> writes:
+>
+>> Some compilers (older than gcc 4.5 and clang 2.9) do support
+>> __attribute__ ((deprecated)) but not
+>> __attribute__ ((deprecated("message"))).
+>>
+>> Check (clang) and know (gcc) which versions support which variants
+>> and make two definitions of define NOTMUCH_DEPRECATED macro;
+>> one with and and one without the ("message") part.
+>>
+>> __has_extension() replacement was modeled after __has_attribute()
+>> definition in compat/function-attributes.h. Thanks Justus.
+>
+> Hi Tomi;
+>
+> I keep coming back to review this patch, but I'm blocked by the fact
+> that clang++ is broken on Debian (and lots of other places, I guess) for
+> months.
+>
+>         https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797038
+
+Personally I am not fond of the commit message but I don't want to
+emphasize the change by sending an updated one. We could move it
+to *moreinfo* to get it out of our ways for the time being -- and
+see whether things stabilize (to one way or another) to decide 
+whether to push this further. 
+
+>
+> d
+
+Tomi