From: Nicolas Kaiser Date: Fri, 4 Mar 2011 23:16:26 +0000 (+0100) Subject: transport-helper.c: fix check for (size_t < 0) X-Git-Tag: v1.7.5-rc0~93 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=803dbdb9686f249e88fae8530b5306d6eea62c1b;p=git.git transport-helper.c: fix check for (size_t < 0) 'bytes' is of type size_t which is unsigned thus can't be negative. But the assigned write() returns ssize_t, and -1 on error. For testing < 0, 'bytes' needs to be of a signed type. Signed-off-by: Nicolas Kaiser Signed-off-by: Junio C Hamano --- diff --git a/transport-helper.c b/transport-helper.c index 4e4754c32..ba06b70cc 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -973,7 +973,7 @@ static int udt_do_read(struct unidirectional_transfer *t) */ static int udt_do_write(struct unidirectional_transfer *t) { - size_t bytes; + ssize_t bytes; if (t->bufuse == 0) return 0; /* Nothing to write. */