From: Marcus Brinkmann <mb@g10code.com>
Date: Thu, 18 Jun 2009 12:38:55 +0000 (+0000)
Subject: 2009-06-18  Marcus Brinkmann  <marcus@g10code.de>
X-Git-Tag: gpgme-1.2.0@1385~4
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7fbc9cdcff2563829bc30cf65b28eaee10355e35;p=gpgme.git

2009-06-18  Marcus Brinkmann  <marcus@g10code.de>

	* context.h (CTX_OP_DATA_MAGIC): New macro.
	(struct ctx_op_data): New member MAGIC.
	* op-support.c (_gpgme_op_data_lookup): Initialize magic.
	* gpgme.c (gpgme_result_unref, gpgme_result_ref): Check magic.
---

diff --git a/trunk/src/ChangeLog b/trunk/src/ChangeLog
index d7b4592..95b5f2d 100644
--- a/trunk/src/ChangeLog
+++ b/trunk/src/ChangeLog
@@ -1,3 +1,10 @@
+2009-06-18  Marcus Brinkmann  <marcus@g10code.de>
+
+	* context.h (CTX_OP_DATA_MAGIC): New macro.
+	(struct ctx_op_data): New member MAGIC.
+	* op-support.c (_gpgme_op_data_lookup): Initialize magic.
+	* gpgme.c (gpgme_result_unref, gpgme_result_ref): Check magic.
+
 2009-06-16  Marcus Brinkmann  <marcus@g10code.de>
 
 	* gpgme.c (gpgme_result_unref): Hot fix to release a lock.
diff --git a/trunk/src/context.h b/trunk/src/context.h
index 63af1d1..e98e7be 100644
--- a/trunk/src/context.h
+++ b/trunk/src/context.h
@@ -42,8 +42,14 @@ typedef enum
   } ctx_op_data_id_t;
 
 
+/* "gpgmeres" in ASCII.  */
+#define CTX_OP_DATA_MAGIC 0x736572656d677067ULL
 struct ctx_op_data
 {
+  /* A magic word just to make sure people don't deallocate something
+     that ain't a result structure.  */
+  unsigned long long magic;
+
   /* The next element in the linked list, or NULL if this is the last
      element.  Used by op data structures linked into a context.  */
   struct ctx_op_data *next;
diff --git a/trunk/src/gpgme.c b/trunk/src/gpgme.c
index 3283b34..56caf59 100644
--- a/trunk/src/gpgme.c
+++ b/trunk/src/gpgme.c
@@ -189,6 +189,8 @@ gpgme_result_ref (void *result)
 
   data = result - sizeof (struct ctx_op_data);
 
+  assert (data->magic == CTX_OP_DATA_MAGIC);
+
   LOCK (result_ref_lock);
   data->references++;
   UNLOCK (result_ref_lock);
@@ -205,6 +207,8 @@ gpgme_result_unref (void *result)
 
   data = result - sizeof (struct ctx_op_data);
 
+  assert (data->magic == CTX_OP_DATA_MAGIC);
+
   LOCK (result_ref_lock);
   if (--data->references)
     {
diff --git a/trunk/src/op-support.c b/trunk/src/op-support.c
index 19b2420..c3ba778 100644
--- a/trunk/src/op-support.c
+++ b/trunk/src/op-support.c
@@ -48,6 +48,7 @@ _gpgme_op_data_lookup (gpgme_ctx_t ctx, ctx_op_data_id_t type, void **hook,
       data = calloc (1, sizeof (struct ctx_op_data) + size);
       if (!data)
 	return gpg_error_from_errno (errno);
+      data->magic = CTX_OP_DATA_MAGIC;
       data->next = ctx->op_data;
       data->type = type;
       data->cleanup = cleanup;