From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 19 Oct 2007 19:33:38 +0000 (-0000)
Subject: Refactor _merge_logentries() to make it a little more efficient.
X-Git-Tag: v2.2_pre1~587
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7f3db57c5feb631f6ff45b40ec45f1721e144a1c;p=portage.git

Refactor _merge_logentries() to make it a little more efficient.

svn path=/main/trunk/; revision=8184
---

diff --git a/pym/portage/elog/__init__.py b/pym/portage/elog/__init__.py
index b9cc3f659..e1df6d9bd 100644
--- a/pym/portage/elog/__init__.py
+++ b/pym/portage/elog/__init__.py
@@ -18,13 +18,12 @@ def _merge_logentries(a, b):
 	phases = set(a)
 	phases.update(b)
 	for p in phases:
-		rValue[p] = []
-		if a.has_key(p):
-			for x in a[p]:
-				rValue[p].append(x)
-		if b.has_key(p):
-			for x in b[p]:
-				rValue[p].append(x)
+		merged_msgs = []
+		rValue[p] = merged_msgs
+		for d in a, b:
+			msgs = d.get(p)
+			if msgs:
+				merged_msgs.extend(msgs)
 	return rValue
 
 def _combine_logentries(logentries):