From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 21 Jan 2014 13:58:43 +0000 (+0200)
Subject: Re: [PATCH] notmuch dump: default to batch-tag format.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7e7d353afb242abd6c981560f7c8bc94f8704739;p=notmuch-archives.git

Re: [PATCH] notmuch dump: default to batch-tag format.
---

diff --git a/1c/f93dcdec52d1532514ca09b0d9486b87727841 b/1c/f93dcdec52d1532514ca09b0d9486b87727841
new file mode 100644
index 000000000..80a640ffc
--- /dev/null
+++ b/1c/f93dcdec52d1532514ca09b0d9486b87727841
@@ -0,0 +1,103 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 17984431FBD
+	for <notmuch@notmuchmail.org>; Tue, 21 Jan 2014 05:59:00 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Z9tQb5JFuYdf for <notmuch@notmuchmail.org>;
+	Tue, 21 Jan 2014 05:58:52 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 651A2431FAF
+	for <notmuch@notmuchmail.org>; Tue, 21 Jan 2014 05:58:52 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 7F0F51000B3;
+	Tue, 21 Jan 2014 15:58:43 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: david@tethera.net, notmuch@notmuchmail.org
+Subject: Re: [PATCH] notmuch dump: default to batch-tag format.
+In-Reply-To: <1390311688-1491-1-git-send-email-david@tethera.net>
+References: <1390311688-1491-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.17+34~g98b959f (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Tue, 21 Jan 2014 15:58:43 +0200
+Message-ID: <m24n4xo2r0.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 21 Jan 2014 13:59:00 -0000
+
+On Tue, Jan 21 2014, david@tethera.net wrote:
+
+> From: David Bremner <david@tethera.net>
+>
+> Although we didn't formally deprecate the old format, the new one has
+> been available for a year.
+> ---
+>  NEWS           | 10 ++++++++++
+>  notmuch-dump.c |  2 +-
+>  2 files changed, 11 insertions(+), 1 deletion(-)
+>
+> diff --git a/NEWS b/NEWS
+> index 28788d8..bdb248e 100644
+> --- a/NEWS
+> +++ b/NEWS
+> @@ -1,3 +1,13 @@
+> +Notmuch 0.18 (2014-xx-xx)
+> +=========================
+
+I tried to advocate Notmuch 0.18 (UNRELEASED) during last development
+cycle -- in followu ========================= p patch (if any -- 
+with manpage change) this change could also be made.
+
+> +
+> +Command-Line Interface
+> +----------------------
+> +
+> +`notmuch dump` now defaults to `batch-tag` format.
+> +
+> +  The old format is still available with `--format=sup`.
+> +
+>  Notmuch 0.17 (2013-12-30)
+>  =========================
+>  
+> diff --git a/notmuch-dump.c b/notmuch-dump.c
+> index f8edda7..158142f 100644
+> --- a/notmuch-dump.c
+> +++ b/notmuch-dump.c
+> @@ -40,7 +40,7 @@ notmuch_dump_command (notmuch_config_t *config, int argc, char *argv[])
+>      char *output_file_name = NULL;
+>      int opt_index;
+>  
+> -    int output_format = DUMP_FORMAT_SUP;
+> +    int output_format = DUMP_FORMAT_BATCH_TAG;
+
+This part looks good.
+
+>  
+>      notmuch_opt_desc_t options[] = {
+>  	{ NOTMUCH_OPT_KEYWORD, &output_format, "format", 'f',
+> -- 
+
+Tomi