From: David Bremner <david@tethera.net>
Date: Sat, 8 Aug 2015 05:33:56 +0000 (+0200)
Subject: [PATCH] fixup! lib: Add per-message last modification tracking
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7dcb1043283e891f707044ebff66ff0f9766fa8a;p=notmuch-archives.git

[PATCH] fixup! lib: Add per-message last modification tracking
---

diff --git a/19/f561444ab11f0abe76b5c3dc492b9f0b7fa144 b/19/f561444ab11f0abe76b5c3dc492b9f0b7fa144
new file mode 100644
index 000000000..d8f9f6a48
--- /dev/null
+++ b/19/f561444ab11f0abe76b5c3dc492b9f0b7fa144
@@ -0,0 +1,75 @@
+Return-Path: <bremner@tesseract.cs.unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 81EBB6DE0261
+ for <notmuch@notmuchmail.org>; Fri,  7 Aug 2015 22:35:56 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.141
+X-Spam-Level: 
+X-Spam-Status: No, score=0.141 tagged_above=-999 required=5 tests=[AWL=0.131, 
+ T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 7NwPCE1pdHGw for <notmuch@notmuchmail.org>;
+ Fri,  7 Aug 2015 22:35:53 -0700 (PDT)
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
+ by arlo.cworth.org (Postfix) with ESMTPS id 005D96DE020B
+ for <notmuch@notmuchmail.org>; Fri,  7 Aug 2015 22:35:52 -0700 (PDT)
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
+ (envelope-from <bremner@tesseract.cs.unb.ca>)
+ id 1ZNwlo-0000e3-Fi; Sat, 08 Aug 2015 05:34:13 +0000
+Received: (nullmailer pid 2767 invoked by uid 1000); Sat, 08 Aug 2015
+ 05:33:58 -0000
+From: David Bremner <david@tethera.net>
+To: Daniel Schoepe <daniel@schoepe.org>, David Bremner <david@tethera.net>,
+ notmuch@notmuchmail.org
+Subject: [PATCH] fixup! lib: Add per-message last modification tracking
+Date: Sat,  8 Aug 2015 07:33:56 +0200
+Message-Id: <1439012036-2629-1-git-send-email-david@tethera.net>
+X-Mailer: git-send-email 2.1.4
+In-Reply-To: <878u9nk0st.fsf@schoepe.localhost>
+References: <878u9nk0st.fsf@schoepe.localhost>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 08 Aug 2015 05:35:56 -0000
+
+---
+
+Now that I take a second look at the code, I think Austin's original
+commit is correct, if a bit terse. Here is how I have expanded it in
+the revised series.
+
+ lib/database.cc | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/lib/database.cc b/lib/database.cc
+index 0650c63..bab3334 100644
+--- a/lib/database.cc
++++ b/lib/database.cc
+@@ -1473,8 +1473,9 @@ notmuch_database_upgrade (notmuch_database_t *notmuch,
+ 		_notmuch_message_upgrade_folder (message);
+ 
+ 	    /* Prior to NOTMUCH_FEATURE_LAST_MOD, messages did not
+-	     * track modification revisions.  Give all messages a
+-	     * revision of 1.
++	     * track modification revisions.  Give all messages the
++	     * next available revision; since we just started tracking
++	     * revisions for this database, that will be 1.
+ 	     */
+ 	    if (new_features & NOTMUCH_FEATURE_LAST_MOD)
+ 		_notmuch_message_upgrade_last_mod (message);
+-- 
+2.1.4
+