From: stevenknight <stevenknight@fdb21ef1-2011-0410-befe-b5e4ea1792b1>
Date: Thu, 17 Dec 2009 02:09:50 +0000 (+0000)
Subject: Fix the time-scons.py --logfiles option.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7c717c472435495d40f6b4ae8cfd9d516a847cf0;p=scons.git

Fix the time-scons.py --logfiles option.


git-svn-id: http://scons.tigris.org/svn/scons/trunk@4555 fdb21ef1-2011-0410-befe-b5e4ea1792b1
---

diff --git a/bin/time-scons.py b/bin/time-scons.py
index 10684e09..90c69851 100644
--- a/bin/time-scons.py
+++ b/bin/time-scons.py
@@ -114,9 +114,11 @@ class CommandRunner:
             if stdout is sys.stdout:
                 # Same as passing sys.stdout, except works with python2.4.
                 subout = None
-            else:
+            elif stdout is None:
                 # Open pipe for anything else so Popen works on python2.4.
                 subout = subprocess.PIPE
+            else:
+                subout = stdout
             if stderr is sys.stderr:
                 # Same as passing sys.stdout, except works with python2.4.
                 suberr = None
@@ -124,19 +126,12 @@ class CommandRunner:
                 # Merge with stdout if stderr isn't specified.
                 suberr = subprocess.STDOUT
             else:
-                # Open pipe for anything else so Popen works on python2.4.
-                suberr = subprocess.PIPE
+                suberr = stderr
             p = subprocess.Popen(command,
                                  shell=(sys.platform == 'win32'),
                                  stdout=subout,
                                  stderr=suberr)
             p.wait()
-            if stdout is None:
-                self.stdout = p.stdout.read()
-            elif stdout is not sys.stdout:
-                stdout.write(p.stdout.read())
-            if stderr not in (None, sys.stderr):
-                stderr.write(p.stderr.read())
             return p.returncode
 
     def run(self, command, display=None, stdout=None, stderr=None):