From: David Bremner <david@tethera.net>
Date: Wed, 15 Jan 2014 13:45:07 +0000 (+2000)
Subject: Re: [PATCH 2/2] lib: fix error handling
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7c4965df23d7032500500d43de5f16fc123fc701;p=notmuch-archives.git

Re: [PATCH 2/2] lib: fix error handling
---

diff --git a/a1/d57bae85265ea4a27febe080289f8adf7c99e2 b/a1/d57bae85265ea4a27febe080289f8adf7c99e2
new file mode 100644
index 000000000..612ba0caf
--- /dev/null
+++ b/a1/d57bae85265ea4a27febe080289f8adf7c99e2
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1ADE3431FBD
+	for <notmuch@notmuchmail.org>; Wed, 15 Jan 2014 05:45:22 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 2Ibj+4AGx9Tm for <notmuch@notmuchmail.org>;
+	Wed, 15 Jan 2014 05:45:14 -0800 (PST)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 57E03431FAF
+	for <notmuch@notmuchmail.org>; Wed, 15 Jan 2014 05:45:14 -0800 (PST)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1W3QmN-0005pJ-C9; Wed, 15 Jan 2014 09:45:11 -0400
+Received: (nullmailer pid 25698 invoked by uid 1000); Wed, 15 Jan 2014
+	13:45:07 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, Tomi Valkeinen <tomi.valkeinen@iki.fi>, 
+	notmuch@notmuchmail.org
+Subject: Re: [PATCH 2/2] lib: fix error handling
+In-Reply-To: <m2txd7lh26.fsf@guru.guru-group.fi>
+References: <1384837831-9206-1-git-send-email-tomi.valkeinen@iki.fi>
+	<1384837831-9206-2-git-send-email-tomi.valkeinen@iki.fi>
+	<m2txd7lh26.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.17+30~g50677dd (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Wed, 15 Jan 2014 09:45:07 -0400
+Message-ID: <87vbxlickc.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 15 Jan 2014 13:45:22 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+>
+> Althoug this adds the library fprintf() count by one this is important
+> and consistent fix to the library...
+>
+
+replacing a fprintf+exit by an fprintf doesn't actually increase the
+fprintf count ;).
+
+d