From: Marco Costalba Date: Sat, 5 Jan 2008 08:57:24 +0000 (+0100) Subject: git-stash: use stdout instead of stderr for non error messages X-Git-Tag: v1.5.4-rc3~42 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7c390d90e8b6322948f45cecc658d62813c0d5ae;p=git.git git-stash: use stdout instead of stderr for non error messages Some scripts and libraries check stderr to detect a failing command, instead of checking the exit code. Because the output from git-status is not primarily for machine consumption, it would not hurt to send these messages to stdout instead and it will make it easier to drive the command for such callers. Signed-off-by: Marco Costalba Signed-off-by: Junio C Hamano --- diff --git a/git-stash.sh b/git-stash.sh index 06cb177ec..4d5e5c0be 100755 --- a/git-stash.sh +++ b/git-stash.sh @@ -86,7 +86,7 @@ save_stash () { if no_changes then - echo >&2 'No local changes to save' + echo 'No local changes to save' exit 0 fi test -f "$GIT_DIR/logs/$ref_stash" || @@ -99,7 +99,7 @@ save_stash () { git update-ref -m "$stash_msg" $ref_stash $w_commit || die "Cannot save the current status" - printf >&2 'Saved working directory and index state "%s"\n' "$stash_msg" + printf 'Saved working directory and index state "%s"\n' "$stash_msg" } have_stash () { @@ -229,7 +229,7 @@ create) if test $# -eq 0 then save_stash && - echo >&2 '(To restore them type "git stash apply")' && + echo '(To restore them type "git stash apply")' && git-reset --hard else usage